Line 360 checks 'lines' which was set to null but never set to anything else. I suspect you mean:
if (flot_obj.data_.lines==null) {
Doing this works for me.
Also, I wanted to add other graph options beyond what you've supported around lines 418, so I added another if statement for each of them. Perhaps this isn't the best way to do it? As it is, flot has many more options you are not supporting, some of which other users may require.
Apologies if this isn't the right place to submit this, I don't see a bugtracker._
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
As for the other options, yes, it would be good to support them.
The current code is indeed somewhat limited… we implemented only what was needed for the use cases we were aware of.
(we are somewhat effort limited)
If you send me the patch, I would be happy to commit it.
Thanks,
Igor
PS: We don't have a bug tracker because we never had external contributors before.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I found a few issues:
Line 360 checks 'lines' which was set to null but never set to anything else. I suspect you mean:
if (flot_obj.data_.lines==null) {
Doing this works for me.
Also, I wanted to add other graph options beyond what you've supported around lines 418, so I added another if statement for each of them. Perhaps this isn't the best way to do it? As it is, flot has many more options you are not supporting, some of which other users may require.
Apologies if this isn't the right place to submit this, I don't see a bugtracker._
Yep. You have found a bug ;)
As for the other options, yes, it would be good to support them.
The current code is indeed somewhat limited… we implemented only what was needed for the use cases we were aware of.
(we are somewhat effort limited)
If you send me the patch, I would be happy to commit it.
Thanks,
Igor
PS: We don't have a bug tracker because we never had external contributors before.