Menu

multi_rra not implemented?

2013-08-07
2013-11-01
  • Marc DeTrano

    Marc DeTrano - 2013-08-07

    I noticed the multi_rra option for rrdflot_defaults did not seem to actually be implemented anywhere in version 0.6.4.

    Not sure if this accomplishes the intent of that option, but I made a quick one liner patch for rrdFlot.js to show the Consolidation Function name in the list of RRAs shown in the Resolution: select input.

    @@ -280,6 +280,7 @@
         var rows=rra.getNrRows();
         var period=step*rows;
         var rra_label=rfs_format_time(step)+" ("+rfs_format_time(period)+" total)";
    +    if (this.rrdflot_defaults.multi_rra) rra_label+=" "+rra.getCFName();
         form_el.appendChild(new Option(rra_label,i));
       }
         if(this.rrdflot_defaults.use_rra) {form_el.selectedIndex = this.rrdflot_defaults.rra;}
    
     
  • Igor Sfiligoi

    Igor Sfiligoi - 2013-11-01

    Hi Marc.

    First, sorry for the long absence.

    Looking at the code, you are defintiely right;
    multi_rra was never impemented!

    Your patch seems to be the right thing to do...
    will commit it and release it with the next version.

    Thanks,
    Igor

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.