[javascriptlint-commit] SF.net SVN: javascriptlint:[369] trunk

[<mat...@us...>]

Revision: 369
          http://sourceforge.net/p/javascriptlint/code/369
Author:   matthiasmiller
Date:     2016-12-29 21:57:52 +0000 (Thu, 29 Dec 2016)
Log Message:
-----------
Improve error location for trailing comma error.

Modified Paths:
--------------
    trunk/javascriptlint/lint.py
    trunk/tests/warnings/trailing_comma_in_array.js

Added Paths:
-----------
    trunk/tests/warnings/trailing_comma.js

Modified: trunk/javascriptlint/lint.py
===================================================================
--- trunk/javascriptlint/lint.py	2016-12-29 21:50:27 UTC (rev 368)
+++ trunk/javascriptlint/lint.py	2016-12-29 21:57:52 UTC (rev 369)
@@ -556,7 +556,8 @@
         except lintwarnings.LintWarning, warning:
             # TODO: This is ugly hardcoding to improve the error positioning of
             # "missing_semicolon" errors.
-            if visitor.warning in ('missing_semicolon', 'missing_semicolon_for_lambda'):
+            if visitor.warning in ('missing_semicolon', 'missing_semicolon_for_lambda',
+                                   'trailing_comma', 'trailing_comma_in_array'):
                 offset = warning.node.end_offset
             else:
                 offset = None

Added: trunk/tests/warnings/trailing_comma.js
===================================================================
--- trunk/tests/warnings/trailing_comma.js	                        (rev 0)
+++ trunk/tests/warnings/trailing_comma.js	2016-12-29 21:57:52 UTC (rev 369)
@@ -0,0 +1,7 @@
+function trailing_comma() {
+    var o = {
+        outer: {
+            inner: 1
+        }, /*warning:trailing_comma*/
+    };
+}

Modified: trunk/tests/warnings/trailing_comma_in_array.js
===================================================================
--- trunk/tests/warnings/trailing_comma_in_array.js	2016-12-29 21:50:27 UTC (rev 368)
+++ trunk/tests/warnings/trailing_comma_in_array.js	2016-12-29 21:57:52 UTC (rev 369)
@@ -13,4 +13,9 @@
         2,
         3, /*warning:trailing_comma_in_array*/
     ];
+    a = [
+        {
+            prop: 1
+        }, /*warning:trailing_comma_in_array*/
+    ];
 }

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.