[javascriptlint-commit] SF.net SVN: javascriptlint:[318] trunk

[<mat...@us...>]

Revision: 318
          http://sourceforge.net/p/javascriptlint/code/318
Author:   matthiasmiller
Date:     2013-09-30 20:59:56 +0000 (Mon, 30 Sep 2013)
Log Message:
-----------
Fix case preservation in control comments.

Modified Paths:
--------------
    trunk/javascriptlint/lint.py
    trunk/tests/warnings/unreferenced_identifier.js

Modified: trunk/javascriptlint/lint.py
===================================================================
--- trunk/javascriptlint/lint.py	2013-09-30 20:53:58 UTC (rev 317)
+++ trunk/javascriptlint/lint.py	2013-09-30 20:59:56 UTC (rev 318)
@@ -48,8 +48,8 @@
 
 def _parse_control_comment(comment):
     """ Returns None or (keyword, parms) """
-    comment_atom = comment.atom.lower().strip()
-    if comment_atom.startswith('jsl:'):
+    comment_atom = comment.atom.strip()
+    if comment_atom.lower().startswith('jsl:'):
         control_comment = comment_atom[4:]
     elif comment_atom.startswith('@') and comment_atom.endswith('@'):
         control_comment = comment_atom[1:-1]
@@ -70,8 +70,8 @@
     )
     for keyword in keywords:
         # The keyword must either match or be separated by a space.
-        if control_comment == keyword or \
-            (control_comment.startswith(keyword) and \
+        if control_comment.lower() == keyword or \
+            (control_comment.lower().startswith(keyword) and \
              control_comment[len(keyword)].isspace()):
             parms = control_comment[len(keyword):].strip()
             return (comment, keyword, parms.strip())

Modified: trunk/tests/warnings/unreferenced_identifier.js
===================================================================
--- trunk/tests/warnings/unreferenced_identifier.js	2013-09-30 20:53:58 UTC (rev 317)
+++ trunk/tests/warnings/unreferenced_identifier.js	2013-09-30 20:59:56 UTC (rev 318)
@@ -98,5 +98,9 @@
         }
     }
 
+    function test_unused_camel_case(CamelCaseParm) { /*warning:unreferenced_function*/
+        /*jsl:unused CamelCaseParm*/
+    }
+
     return get_callback(42);
 }

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.