[javascriptlint-commit] SF.net SVN: javascriptlint:[260] trunk/setup.py

[<mat...@us...>]

Revision: 260
          http://javascriptlint.svn.sourceforge.net/javascriptlint/?rev=260&view=rev
Author:   matthiasmiller
Date:     2009-10-03 19:20:23 +0000 (Sat, 03 Oct 2009)

Log Message:
-----------
Python 2.4 doesn't have subprocess.check_call.

Modified Paths:
--------------
    trunk/setup.py

Modified: trunk/setup.py
===================================================================
--- trunk/setup.py	2009-10-03 18:17:28 UTC (rev 259)
+++ trunk/setup.py	2009-10-03 19:20:23 UTC (rev 260)
@@ -7,18 +7,25 @@
 import subprocess
 import sys
 
+class _MakefileError(Exception):
+    pass
+
 def _runmakefiles(distutils_dir, build_opt=1, args=[]):
     # First build SpiderMonkey.
-    subprocess.check_call(['make', '-f', 'Makefile.ref', '-C',
+    ret = subprocess.call(['make', '-f', 'Makefile.ref', '-C',
                            'spidermonkey/src', 'BUILD_OPT=%i' % build_opt] + \
-                            args)
+                           args)
+    if ret != 0:
+        raise _MakefileError, 'Error running make.'
 
     # Then copy the files to the build directory.
     env = dict(os.environ)
     if distutils_dir:
         env['DISTUTILS_DIR'] = distutils_dir
-    subprocess.check_call(['make', '-f', 'Makefile.SpiderMonkey',
-                          'BUILD_OPT=%i' % build_opt] + args, env=env)
+    ret = subprocess.call(['make', '-f', 'Makefile.SpiderMonkey',
+                           'BUILD_OPT=%i' % build_opt] + args, env=env)
+    if ret != 0:
+        raise _MakefileError, 'Error running make.'
 
 class _MyBuild(distutils.command.build.build):
     def run(self):


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.