Re: [Javagit-users] Cookbook

[James L. <jam...@gm...>]

On Mon, Aug 4, 2008 at 11:27 AM, James Linder <jam...@gm...> wrote:
> [inline]
>
> On Mon, Aug 4, 2008 at 11:19 AM, Nutan Singh <ns...@ci...> wrote:
>> Hi,
>>
>> In,
>>
>> "Adding files to the repository
>>
>> // The "/path/to/working/tree" is the directory containing the .git directory
>> File workingTreePath = new File("/path/to/working/tree");
>> WorkingTree wt = WorkingTree.getInstance(workingTreePath);
>>
>> GitFile file = new GitFile("path/relative/to/workingtree/root.txt", wt);
>>
>> GitAddResponse ar = wt.add();
>> "
>>
>> Shouldn't the last line be
>> GitAddResponse ar = file.add(); ?
>
> I think it can be either.  file.add() will add that specific file.
> wt.add() will add the working tree root and everything under it; it's
> like running the command 'git add .' when in the working tree root.

At least, that is my understanding of how wt.add() is supposed to
work.  In any case, wt.add() should be made to work in a predictable
manner and have its javadocs clearly written to explain how it works.

>> A bug (http://sourceforge.net/tracker/index.php?func=detail&aid=2037398&group_id=233450&atid=1089899)
>> is also raised about add not working for workingTree. I think the
>> reason is improper calling, and, its not a bug.
>>
>> Thanks,
>> Nutan
>