[Javagit-bugs] [ javagit-Bugs-2029073 ] Make GitAddOptions optional

[SourceForge.net <no...@so...>]

Bugs item #2029073, was opened at 2008-07-26 21:22
Message generated for change (Comment added) made by jhlinder
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1089899&aid=2029073&group_id=233450

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Commands API
>Group: v0.1.0 (fixed in)
>Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Andrew Case (andrewcase)
Assigned to: Gurdeep Dhindsa (dhindsg)
Summary: Make GitAddOptions optional

Initial Comment:
I'm wondering if api commands can have optional 'options' when they really are optional.  I see it
done both ways (git-mv vs. git-add).  I would think that if the command line options are options, so should the object paramaters:


Can GitAdd provide:

public GitAddResponse add(java.io.File repositoryPath,
                          java.io.File file)
                   throws java.io.IOException,
                          JavaGitException

as well as

public GitAddResponse add(java.io.File repositoryPath,
                          GitAddOptions options,
                          java.io.File file)
                   throws java.io.IOException,
                          JavaGitException

Thanks,

--
Drew



----------------------------------------------------------------------

>Comment By: James H. Linder (jhlinder)
Date: 2008-08-03 18:30

Message:
Logged In: YES 
user_id=1099750
Originator: NO

Closing.

----------------------------------------------------------------------

Comment By: James H. Linder (jhlinder)
Date: 2008-08-03 17:26

Message:
Logged In: YES 
user_id=1099750
Originator: NO

Gurdeep,

I finished providing comments on this fix.  Please comment in the bug once
you have reviewed my comments and committed changes.

Thanks,

James

----------------------------------------------------------------------

Comment By: James H. Linder (jhlinder)
Date: 2008-08-03 14:52

Message:
Logged In: YES 
user_id=1099750
Originator: NO

Gurdeep,

What revision did you commit these changes on? 

Thanks,

James

----------------------------------------------------------------------

Comment By: Gurdeep Dhindsa (dhindsg)
Date: 2008-08-03 02:46

Message:
Logged In: YES 
user_id=2143686
Originator: NO

Two additional APIs have been added to GitAdd with no options needed.

-  public GitAddResponse add(File repositoryPath, File file) throws
JavaGitException, IOException;
-  public GitAddResponse add(File repositoryPath, List<File> filePaths)
throws JavaGitException, IOException;

----------------------------------------------------------------------

Comment By: Gurdeep Dhindsa (dhindsg)
Date: 2008-08-03 02:44

Message:
Logged In: YES 
user_id=2143686
Originator: NO

Two additional APIs have been added to GitAdd with no options needed.

-  public GitAddResponse add(File repositoryPath, File file) throws
JavaGitException, IOException;
-  public GitAddResponse add(File repositoryPath, List<File> filePaths)
throws JavaGitException, IOException;

----------------------------------------------------------------------

Comment By: James H. Linder (jhlinder)
Date: 2008-08-03 01:08

Message:
Logged In: YES 
user_id=1099750
Originator: NO

Gurdeep, Nutan, 

If one of you can fix this before the build, that would be great.

James

----------------------------------------------------------------------

Comment By: nutans (nutans)
Date: 2008-07-31 10:37

Message:
Logged In: YES 
user_id=2152864
Originator: NO

Gurdeep,

Have you done this already(on your machine)? Or, do you want me to assign
it to myself and fix the problem?

~Nutan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1089899&aid=2029073&group_id=233450