Re: [Javagit-codereview] JavaGitConfiguration

[Ross S. <ros...@ny...>]

Wooo - I'm back in Crucible.  Can I get some feedback on my stuff here?

http://linserv3.cims.nyu.edu:11000/cru/Javagit-9

On Jul 29, 2008, at 1:34 AM, Ross Snyder wrote:

> I just checked in my JavaGitConfiguration stuff I've been working  
> on for a little while.  I'd appreciate some feedback - but I can't  
> create a code review for it at the moment (see my previous e-mail  
> about being locked out of Crucible).  It's r549, in the branch  
> branches/reviews/rs2705/2.  As soon as I can get back into  
> Crucible, I'll create a real code review.
>
> The JavaGitConfiguration class is all-static as of now, so it  
> exists globally and can be accessed from anywhere.  Is that cool?   
> When you attempt to set the path, it tries to run a git --version  
> command to check the path's validity.
>
> I put the parser and response objects for the git --version call  
> inline, since they're only used for this one specific purpose in  
> JavaGitConfiguration.  Is that kosher, or would you recommend I  
> move them outside of the class?
>
> Once I get some feedback and everyone signs off on it, I'll go  
> through the code and hook up  
> JavaGitConfiguration.getGitCommandPrefix() anywhere we run git.  (I  
> looked at Google Guice, but in the interest of not introducing 3rd- 
> party library dependencies, I'm willing to do it the old-fashioned  
> way - by hand).