Menu

#3 Naming conventions, which are used, wether an element defines a value, are too restrictive

1.0.0
closed
Bug (3)
2014-03-27
2014-03-27
No

The naming conventions which are used by the class AbstractFeedElementParserAdapter to determine, whether an element, which is processed by a parser, does contain a value, which is defined to belong to the feed are too restrictive. At the moment, parsing the value of an element must be done inside a private method, which does not expect any parameters and does have the return type 'void'. But when further steps of the parser rely on the result of parsing such a value, this method must be able to return a value and receive various parameters. Therefore the implementation of the method hasDefinedValue():boolen in the class AbstractFeedElementParserAdapter must be adapted to also take private methods into consideration, which have any return type and parameters.

Discussion

  • Michael Rapp

    Michael Rapp - 2014-03-27
    • status: open --> accepted
     
  • Michael Rapp

    Michael Rapp - 2014-03-27
    • status: accepted --> closed

    Fixed issue and released bugfix version 1.0.3.

     

    Last edit: Michael Rapp 2014-03-27

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.