Re: [Java-player-developers] patch for PlayerClient.close()

[Kurt K. <kon...@AI...>]

It would be ok to send the close request, but it would have to be done 
without waiting for a reply, I guess.  I haven't looked at the Player 
code to make sure.  At any rate, this is just a quick fix to make it 
work, I'll update it correctly later.

Cheers --Kurt

Radu Bogdan Rusu wrote:
> Thanks a lot Kurt, I just applied it to the repository.
> 
> Everything looks fine at first glance, but I wonder if closing the 
> sockets directly without unsubscribing will cause any nasty effects on 
> the Player side for some devices.
> 
> Best,
> Radu.
> 
> Kurt Konolige wrote:
>> This function hangs when talking to Stage (haven't tried it with a 
>> real robot).  It's waiting for a response to a device close request, 
>> which Stage never sends.  Took out the close request, just shut down 
>> the I/O, which closes the Stage connection.  Also added setNotThreaded 
>> code to wait for thread to exit.
>>
>> Patch is against the latest SVN.
>>
>> Cheers --Kurt