Unable to login with empty contactlist

[Anonymous]

Hi,

I've been using JML in my android app and it works like a charm. In order to use my app, a lot of users create a new hotmail account. However, users come to me repeatedly with the same bug: contactListInitCompleted is never called when there are no contacts in the user's contact list yet.

So far I have been able to reproduce this with new live.com/hotmail/etc. accounts without any contacts added but I can't seem to figure out what the problem is yet.

The logs show that after the incoming BPL, JML just stops. There's no outgoing ADL (and of course no incoming "ADL OK" either).

Does anyone have a clue where to look?

[Anonymous]

Ok, solution:

net/sf/jml/protocol/soap/ContactList.java:

at line 595, after

int cs_size=cs.length;
Queue<MsnContact> csq= new LinkedList<MsnContact>();
try{

Add:

if(cs_size == 0) {
                    OutgoingADL oADLx = new OutgoingADL(messenger.getActualMsnProtocol());
                    if(firstADLReply) {
                        ADLSent = true;
                    }
                    
                    oADLx.addContacts(csq.toArray(new MsnContact[0]));
                    
                    messenger.send(oADLx);
                } else {
// the for-loop here
}
firstADLReply=false; //prevents calling processInit again! Check: RFS Incoming

[Damian Minkov]

Should be fixed in latest trunk, you can test.

[Anonymous]

Same problem arises; contactListInitCompleted() is never called for some accounts.

[Anonymous]

Somehow it sets firstADLReply to false, even though it's the first loop; must be an error with my implementation.