Menu

contact list patch

Help
2010-01-06
2013-04-29
  • James Lopez

    James Lopez - 2010-01-06

    There was some problems with the contact list at connection (long contact lists were not well processed as well as some other issues)
    So I have made another patch available at: https://sourceforge.net/tracker/?func=detail&aid=2927067&group_id=118829&atid=682291

    Notice that you should have the last SVN snapshot or applied my previous patch in order to the changes have effect!

    This affects the way MSNP>=13 contact lists are handled.

     
  • James Lopez

    James Lopez - 2010-01-07

    Please ignore such patch and download the last SVN snapshot instead, as it had a build issue solved in the last SVN commit!

     
  • ronaldo

    ronaldo - 2010-01-08

    hey  jadestorm,

    this version does not contain the object "MsnContactPending", please amend this.

    thank you very much

     
  • Daniel Henninger

    What MsnContactPending are you referring to?  bluegod also has commit access now  =D  do you know what he's talking about?

     
  • James Lopez

    James Lopez - 2010-01-08

    Hi,

    I don't know any class called MsnContactPending.. I just know a static object from the MsnList class called MsnList.PL used in MSNP>13 but it's just a 'flag', an anyway there was no modifications on such things, just the way retrieving the lists from MSNP>13, but the SOAP replies containing the contacts with such flags were not modifed. For MSNP<13 a LST command instead of ADL was used, but there was also no modification (at least by me) in the content from such lists containing the groups a user belong to…

     
  • Anonymous

    Anonymous - 2010-01-09

    Hello

    Yes, I did that, but it has never been applied on the SVN…

     
  • James Lopez

    James Lopez - 2010-01-09

    Hi!

    Interesting! I didn't check the way PL work so I didn't know there was such issue, anyway for which protocol version could this patch be applied? Mainly because it's interesting that there's some kind of switch if MSNP is less or greater than 13, that I think it should be the one with different PL handling… Perhaps it works on both, but what I'm sure is that Pending Lists are also sent with SOAP, (but this is not send in the first ADL as it doesn't include RL and PL lists) after MSNP>13, I don't know exactly the way are being used in MSNP<13

     
  • Anonymous

    Anonymous - 2010-01-09

    It work with SOAP, so after MSNP13, I guess, I tried with MSNP15 and MSNP18

     
  • Anonymous

    Anonymous - 2010-01-09

    Well, MSNP version don't change SOAP version ^^

     
  • James Lopez

    James Lopez - 2010-01-09

    I know, but what I mean is could it work with MSNP<13 ? Thank you jessou!

     
  • Anonymous

    Anonymous - 2010-01-09

    you're welcome ! It's nice to see that it's useful :)

     
  • James Lopez

    James Lopez - 2010-01-09

    I'll upload it to trunk later, but you must tell me if such function works with MSNP<13, if not I'll have to put some ifs here and there before the commit!

     
  • Anonymous

    Anonymous - 2010-01-09

    It's not : the list stay empty because it uses the processMembers method in ContactService, and I don't know how it works before.

     
  • James Lopez

    James Lopez - 2010-01-10

    The patch has been applied to SVN trunk, although it will only work with MSNP>13 at the moment :)

     
  • Anonymous

    Anonymous - 2010-01-10

    thanks !

     
  • James Lopez

    James Lopez - 2010-01-10

    Related to this issue, I have updated again the SVN with a new event (that *must* be implemented) called ContactAddedMe(), there was another one but the new one differ in the params, now a "pending list" is return!

    This is very interesing so now when someone added the owner, the event will notify us of such action and we can ask the user wether to accept or not, instead of checking if there's someone in the pending list.

    Notice that I didn't check this! but as far as I know now using any MSNP>9 we shouldl get notified about a new add, at least when the user connects to the MSN server.

     
  • ronaldo

    ronaldo - 2010-01-11

    Do you mean now when someone added the owner, the owner can reject the request?

    If so, would you tell which method  I call when the owner want to reject the request?
    That is exactly what I want.

    thank you.

     
  • James Lopez

    James Lopez - 2010-01-11

    The owner gets notified and the owner decides what to do, I think there's no method to call for reject the request, not sure, anyway you can add the friend if you want, or you could simply ignore the request, but I didn't check the way it happen if the request is just ignored, I suppose the friend keeps in the "pending list", so perhaps it's better to remove it from such list, there must be some methods related, I am not sure now if those methods are included in the MsnUser class or others, but using any MSNP>13 you may access those directly from the ContactList class (there is a method like getContactList() to get an object from such class).

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.