I'm thinking of changing something in IncomingUSR, which may be a significant change for someone. Asking is it ok to do it.
The main problem is that in IncomingUSR if their is a problem connecting (to soap services) jml uses fireExceptionCaught to inform the user, and after that logouts (messenger.logout()). Looking at it I think logout is a method with higher abstraction and must not be called internally and must be handled and called from the client, like after receiving fireExceptionCaught.
WDYT?
Regards
damencho
P.S.
In our situation, we had a problem with our msn provider that from time to time (mostly after reconnection) goes in state like its not connected but can receive messages. It was because we handle our state in fireExceptionCaught and start reconnecting and just as it is almost finished and logout comes from within IncomingUSR.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi developers and all,
I'm thinking of changing something in IncomingUSR, which may be a significant change for someone. Asking is it ok to do it.
The main problem is that in IncomingUSR if their is a problem connecting (to soap services) jml uses fireExceptionCaught to inform the user, and after that logouts (messenger.logout()). Looking at it I think logout is a method with higher abstraction and must not be called internally and must be handled and called from the client, like after receiving fireExceptionCaught.
WDYT?
Regards
damencho
P.S.
In our situation, we had a problem with our msn provider that from time to time (mostly after reconnection) goes in state like its not connected but can receive messages. It was because we handle our state in fireExceptionCaught and start reconnecting and just as it is almost finished and logout comes from within IncomingUSR.
I agree your suggestion.
I agree as well, sounds like a good idea.