Re: [Java-gnome-developer] assorted notes
Brought to you by:
afcowie
From: Jeff M. <ku...@gm...> - 2005-03-25 13:04:20
|
Havoc, Thanks for this feedback. Several of the items mentioned below are already on my TODO list. I am currently in the process of splitting out our base classes and utility methods into the java-gnome package. Wednesday and Thursday night I worked on these packages. I am also updating our cairo-java bindings to use this package. This will break the cyclical dependencies between our gtk-java and cairo-java bindings. I hope to have this completed this weekend. At that time I should be able to update cairo-java with the new APIs (I am a little over a week behind). Once my cairo-java is up to date I hope to focus on GDK/GTK. My first step will be to change libgtk-java to use the new utility library. This should be quite easy. Once that is complete I plan to complete the cairo integration. At that time it should be easy to address most of the items you mention below. Thanks for taking the time to look through the code. It is nice to have a fresh set of eyes taking a look. We always apreciate your feedback. btw, have you received your invitation to java-gnome-con? It is the hottest event of the year !! ;-) It is just a simple gathering of Java-GNOME hackers and interested parties at the Red Hat Toronto office April 2nd. There is no formal agenda; just plenty of hacking. You are welcome to attend. On Fri, 25 Mar 2005 02:21:04 -0500, Havoc Pennington <hp...@re...> wrote: > Hi, > > Playing with java-gnome today, I encountered a number of suggestions and > problems, some of them surely my fault (I'm not a Java programmer > really). I'll just write them down and you guys can filter the > worthwhile ones. > > - general observation: http://mail.gnome.org/archives/gtk-devel-list/2005-March/msg00175.html > - please kill color allocation, that's very easy and > nobody understands it... > - main loop should be on the glib level > - kill GtkObject from the hierarchy > > - ah, another one I forgot in the gtk-devel-list post: delete_event should be moved > from GtkWidget to GtkWindow, people confuse it with the destroy signal so it's > a real improvement to do this > > - the constructor for GC should take a Drawable rather than Window > > - I can't seem to construct a Point because of a runtime link error > finding gdk_point_new > > - I can't seem to construct a Segment because the only constructor > takes a Handle > > - the JNI for draw_lines() looks fishy to me (array of Point* instead of > array of Point?) but I'm too lazy to investigate enough to be sure > > - I find Drawable.getDimension() pretty strange; plus the temporary > Dimension object isn't efficient. I'd suggest just getWidth()/Height() > > - I can't figure out how to get a ConfigureEvent on widgets, needed to > use DrawingArea > > - building cairo-java I get an error because jg_jnu.h includes glib.h but > the appropriate cflags -I/usr/include/glib-2.0 weren't on the compile line > > - PDF part of cairo-java is out of date (kristian probably broke it recently) > > - .pc file says "javagnome0.1.jar" but it's installed as "java-gnome0.1.jar" with > a hyphen > > - libgtk-java seems to include Cairo jar but not java-gnome0.1.jar in classpath > > - src/java/org/gnu/gdk/Color.java:163: > gdk_cairo_set_source_color(org.gnu.glib.Handle,org.gnu.glib.Handle) in > org.gnu.gdk.Color cannot be applied to > (org.gnu.javagnome.Handle,org.gnu.glib.Handle) > gdk_cairo_set_source_color(cairo.getHandle(), getHandle()); > ^ > > - the TextView "action" signals should not be exported as signals, they > aren't something application code would connect to (this is true of > all action signals really, they are only used to configure keybindings) > > - isn't the Handle interface pretty expensive vs. just using "long"? > > - there are a lot of members in GObject and Widget as well, which is > quite a bit of overhead... most of them seem listener-related. I wonder > if there's a better approach. > > Hope this is helpful, thanks for the software! > > I haven't worked on bindings stuff since around the GTK+ 2.0 release > time so forgive any rusty thinking. > > Havoc > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > _______________________________________________ > java-gnome-developer mailing list > jav...@li... > https://lists.sourceforge.net/lists/listinfo/java-gnome-developer > -- Jeffrey Morgan "The highest reward for a man's toil is not what he gets for it, but what he becomes by it" - Jon Ruskin |