RE: [Java-gnome-developer] [PATCH] two small patches

[Nicholas R. <ni...@mn...>]

No problem.  i'll put a couple of bugs in bugzilla for these patches.


Another question: In HTMLDocument.java, the handleSubmit method has the
following signature:

protected void handleSubmit(String method, String url, String encoding)

However, in libgtkhtml-2.6.2, the SUBMIT signal gets emitted with these
three arguments (in this order):  action, method, encoding.   So it
seems that it would be more accurate to change the signature of
handleSubmit to this:

protected void handleSubmit(String url, String method, String encoding)

Do you agree with this analysis?  should i submit a patch for this?


One last question (for now :-), is there anyone actively maintaining or
working on libgtkhtml-java?  i would like to add some features (such as
image loading and mouse hover), but i don't want to re-invent the wheel
if someone's already working on this.

Thanks for your help,
Nick

On Thu, 2004-10-28 at 06:46 -0400, Jeffrey Morgan wrote:
> Thank you very much for the patch.  We are currently at a point where
> we are not able to make API changes.  In about a week or two we will
> begin our 2.9 development effort and should be able to apply the patches
> at that time.  I will apply the patch for the getSelected method but
> would ask you to please open a bugzilla report for the remaining diffs.
> When we start 2.9 I will be happy to apply the remaining patch.
> 
> -Jeff
> 
> 
> > -----Original Message-----
> > From: jav...@li...
> > [mailto:jav...@li...]On Behalf Of
> > Nicholas Rahn
> > Sent: Thursday, October 28, 2004 6:16 AM
> > To: jav...@li...
> > Subject: [Java-gnome-developer] [PATCH] two small patches
> > 
> > 
> > Hi,
> > 
> > Here are 2 small patches (diff -u) that I would like to submit for
> > possible inclusion in CVS.
> > 
> > SimpleList.patch
> >   - Fix to avoid a NP exception in getSelected when there is no list
> > element selected.
> >   - Add a new method, remove( String ), which removes the 
> > given element
> > from the list.
> > 
> > HTMLDocument.patch
> >   - Add a new method, loadStream( InputStream, String ), 
> > which loads the
> > page from the given InputStream.  This is useful if you want to use an
> > external tool (for example, Jakarta's HttpClient) to retrieve 
> > the page,
> > rather than using the internal retrieval process provided in
> > loadURL( String ).
> > 
> > 
> > Let me know if you would like the patches in some other form/forum.
> > Comments/critiques are welcome.
> > 
> > Nick
> > 
> > -- 
> > 
> 
>  NOTE: THIS IS A CONFIDENTIAL COMMUNICATION. This transmission is intended
> only for the use of the individuals or entity to which it is addressed. If
> you are not the intended recipient, or the person responsible for delivering
> the message to the intended recipient, please return or delete it
> immediately. Although this e-mail and any attachments are believed to be
> free of any virus or other defect, it is the responsibility of the recipient
> to ensure that it is virus free and no responsibility is accepted by us for
> any loss or damage arising in any way from its unauthorized modification or
> use.
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by:
> Sybase ASE Linux Express Edition - download now for FREE
> LinuxWorld Reader's Choice Award Winner for best database on Linux.
> http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
> _______________________________________________
> java-gnome-developer mailing list
> jav...@li...
> https://lists.sourceforge.net/lists/listinfo/java-gnome-developer
--