Re: [Java-gnome-developer] OptionMenu events etc..

[Mark H. <mh...@ca...>]

On Sun, Oct 05, 2003 at 12:16:37PM +0300, Jonas Berlin wrote:
>   http://xkr47.outerspace.dyndns.org/patches/java-gnome/cvs-031005-2-initializeEvent-addEvents.diff

Thanks.
This looks good. I've tested on my large app and everything seems to
work fine. Did you go through every single widget? Or is there more
still to be done. Also, did you take a look at the gnome widgets?

> The sourceforge cvs was inoperational, or at least I could not log in to 
> in sourceforge yesterday evening.
Were you using anonymous cvs? The developer one where you have to login
requires special cvs privilidges. In any case, sourceforge is generally
rubbish at cvs; trying again a few minutes later often helps.

>  - some classes had addEvents() methods that only called 
> <superclass>.addEvents(), which after my modification (2.) became empty, 
> so I removed those methods (and unnecessary EventMap imports that became 
> unnecessary) altogether.
I'd have prefered to eave them with a comment saying they do anything.
This shows that you've actually thought about it, rather than it being
mistakenly missed out. Not important though. Leave things as they are
now.

>  - some classes didn't have an addEvents() method at all, instead they did 
> what addEvents() used to do directly in the static { ... } block. I 
> thought consistency is bliss, created new addEvents() methods and moved 
> the code there.
I can't remember exactly when add events was implemented. I think Tom
did it all when working on the glade support. Probably just missed a few
classes.

-- 
  .''`. Mark Howard
 : :' :
 `. `'  http://www.tildemh.com 
   `-   mh...@de... | mh...@ti... | mh...@ca...