[Java-gnome-developer] @INSTALL_TARGETS@ confusion

[Santeri P. <sa...@ik...>]

Hello,

I am using the CVS java-gnome version. I noticed the following problem 
in the installation targets:

$ make install
make: *** No rule to make target `gnome', needed by `install'.  Stop.

This is caused by a line in Makefile:

install: gnome glade_install

because there is no "gnome" target. Why? Because the original 
Makefile.in line is:

install: @INSTALL_TARGETS@_install

and INSTALL_TARGETS is defined as "gnome glade". Clearly, appending 
_install to a @ substitution will not work when the substituted variable 
contains more than one element...

This would be simple to fix:

install: $(addsuffix _install,@INSTALL_TARGETS@)

Except that this requires a GNU make to be used. If a requirement for 
GNU make is not wanted, then the other approach is to modify all 
INSTALL_TARGET variable assignments in configure.in to themselves 
include the _install prefix.

PS. This applies to the uninstall target as well.

PPS. A wish: remove @ from all commands for install/uninstall targets. 
It is always disconcerting when "make install" does something that is 
not shown. It makes finding the real culprit for this harder:

$ make install
/usr/bin/install -c -m644 lib/libGTKJava.so.0.8.0 /l/beta/lib
ln: `/l/beta/lib/libGTKJava.so': File exists

(the real culprit is not any "ln" that might be called by 
/usr/bin/install, but the next line, which is @ln ...)

PPPS. And one should always add a "-rm -f xxxx" before using $(LN_S) 
just in case the target already exists.

-- 
sa...@ik...                    I have become death, destroyer of the worlds.