[java-gnome-hackers] Re: [Java-gnome-checkins] CVS: java-gnome/gtk TODO.gtk,1.38,1.39

['Mark H. <mh...@ca...>]

Sorry for being a so slow with everything. I'm afraid I have to put
applying for jobs and doing uni work above java-gnome, even though those
things are a lot less fun.

On Fri, Feb 20, 2004 at 03:39:23PM -0500, Jeffrey Morgan wrote:
> > On Fri, Feb 20, 2004 at 10:23:48AM -0500, Jeffrey Morgan wrote:
> > > 2) The tree control and related classes are a critical component
> > > of the bindings.  Since Mark is busy I plan to spend next week
> > > working on these classes.  Mark, you could really help by sending
> > > an email that would provide an overview of these classes, how they
> > > work together, what you were able to complete and what remains.  
I think you know how they work already - there are also the javadocs if
you're unsure. I've not been able to complete much. What remains is
documented in the todo. 
The ones with the *'s are the most important. I think it's probably best
to leave the others for 2.8 - we don't have time for them. I have no
idea when I'll get time to do any of these, so please do take them if
you can. All that's really needed at this stage is the API design, but
it might require looking deep into the gtk documentation and possibly
even example apps in some cases. I will of course check anything and do
tend to spend time writing emails even when I don't have the time, so
feel free to ask me questions.

** SelectionData enhancements are almost certainly needed for treeDrag*
  TreeModel
****   The "rows-reordered" signal
	  row-changed signal
  TreePath 
	  various new methods
  TreeIter
**  - add ref to treeModel
**  - include many methods from treemodel
  TreeSelection
   // TODO: GtkTreeSelectionFunc ()
   // gtk_tree_selection_set_select_function ()
   tk_tree_selection_unselect_range
  TreeViewColumn
   gtk_tree_view_column_set_cell_data_func() (complex)
**  sort_column_id - should this be dataBlock??
*  gtk_tree_view_column_focus_cell  - since 2.2
  TreeView
   gtk_tree_view_map_expanded_rows ( ?? is it useful?
   gtk_tree_view_enable_model_drag_dest - ??
   gtk_tree_view_enable_model_drag_source -??
   gtk_tree_view_unset_rows_drag_source -??
   gtk_tree_view_unset_rows_drag_dest -??
   gtk_tree_view_set_drag_dest_row - no
   gtk_tree_view_get_drag_dest_row -no
   gtk_tree_view_get_dest_row_at_pos - no
   gtk_tree_view_set_search_equal_func - surely this is not useful?
*  signals: row-activated, row-collapsed, row-expanded
  TreeModelSort ('implements' treemodel and treesortable)
   -don't bother
  TreeModelFilter ('implements' treemdel)
   -complex - questionable
  CellLayout
   - GtkCellLayout is implemented by GtkTreeViewColumn, GtkEntryCompletion, GtkComboBoxEntry and GtkComboBox.
   - leave for 2.8? what's it for?
* CellEditable
*  implemented by GtkEntry and GtkSpinButton.
*  editing-done" signal
  CR Text
+	  - add lots of setProperty methods
	  - type enforcement for attributes??



> > > During my review I added that we should change a couple of the 
> > > classes to Interfaces since they are implemented this way in gtk. 
> > > I did this for FileChooser and implemented a FileChooserHelper 
> > > class to actually implement those methods so there was no 
> > > duplication of code.  Does this make sence for the Tree widgets?
> > I guess. We should probably do the same for the sortable interface for
> > trees.
> 
> Do you think this is a wise move?  You know better than anybody how
> complex these 
I'm not really sure what benefit it brings.
At the moment, ListStore and TreeStore will be the only TreeModels. We
will probably never have support for people to write their own in java
(as is commonly done in c). What benefits are there? I think we should
leave it for trees TBH - there are no immediate benefits and changing
this in the future would not be API-incompatible. 
Please check where treemodelfilter fits in though - i think it is a
wrapper class, but I'm not certain.

> > > Also, I am not real happy with the class name DataBlock.  
DataColumn sounds great. We should update the documentation sometime.
Have you looked at gtkmm documentation - it's very impressive.

-- 
  .''`. Mark Howard
 : :' :
 `. `'  http://www.tildemh.com 
   `-   mh...@de... | mh...@ti... | mh...@ca...