[java-gnome-hackers] RE: [Java-gnome-checkins] CVS: java-gnome/gtk TODO.gtk,1.38,1.39

[Jeffrey M. <Jef...@Br...>]

> On Tue, Feb 17, 2004 at 01:58:19PM -0800, Jeffrey S. Morgan wrote:
> > Added another GTK review
> 
> That's an awful lot of work to do. Jeff - I'm really 
> struggling for time
> at the moment - my uni work is now quite far behind and is 
> just getting
> worse at the moment, so I've not been able to spend much time on
> java-gnome.  The situation will not improve before the release
> unfortunately. 

This is a lot to accomplish and I am not sure all of it can be
completed prior to the beta.  I plan to focus on the following:

1) Over the weekend I hope to focus on the critical miscellaneous
items listed in the TODO.gtk file.
2) The tree control and related classes are a critical component
of the bindings.  Since Mark is busy I plan to spend next week
working on these classes.  Mark, you could really help by sending
an email that would provide an overview of these classes, how they
work together, what you were able to complete and what remains.  

During my review I added that we should change a couple of the 
classes to Interfaces since they are implemented this way in gtk. 
I did this for FileChooser and implemented a FileChooserHelper 
class to actually implement those methods so there was no 
duplication of code.  Does this make sence for the Tree widgets?

Also, I am not real happy with the class name DataBlock.  What these 
really represent are column types.  I know this would break
a lot of code but we should discuss this before our API freeze.
Could we change this to something like ColumnType?  Also, could
these be stored as members of the store so calls to setValue
would not need to pass them as a parameter.  setValue could then
just pass a 0 based column number. 

Let me know what you think.

-Jeff

 NOTE: THIS IS A CONFIDENTIAL COMMUNICATION. This transmission is intended
only for the use of the individuals or entity to which it is addressed. If
you are not the intended recipient, or the person responsible for delivering
the message to the intended recipient, please return or delete it
immediately. Although this e-mail and any attachments are believed to be
free of any virus or other defect, it is the responsibility of the recipient
to ensure that it is virus free and no responsibility is accepted by us for
any loss or damage arising in any way from its unauthorized modification or
use.