Re: [java-gnome-hackers] Re: [Java-gnome-checkins] CVS: java-gnome/gtk/src/java/org/gnu/gtk BindingSet.java,1.3,1.4 ColorSelectionDialog.java,1.7,1.8

[Mark H. <mh...@ca...>]

On Tue, Dec 30, 2003 at 10:54:50PM +0100, Luca De Rugeriis wrote:
> > On Mon, Dec 29, 2003 at 06:45:35PM -0800, Luca De Rugeriis wrote:
> > > + 	 * @param keyval The key value for the BindingSet. It must be a member of {@link org.gnu.gdk.KeySymbol}
> > >   	public boolean activateBindings(int keyval, ModifierType modifier) {
...
> This was the cause of doing so. However if you have a chance, please
> make those changes, cause it's a more correct way of doing things ;)
I think these are now done. 

> > KeySymbols instead of integers, passing keySymbol.getValue() to the
> > native method.
> I'll do this after you've commited the above changes.

> above all the importance of not breaking api/abi . However I was
> assuming that our head branch was the right place to add new classes,
> until we are going to do an api freeze.
That's correct. I was just questioning whether that class needed to be
added at all. 
> So what we need to do before api freeze? (apart from fixing known bugs?)
Add the new classes and add the new methods to existing classes. I've
now added gtk/TODO.gtk, which details exactly what we have to do. 

> They came across right ;) After all open discussion is what open source
> development is all about :)
> At this point I could easily remove those classes. We'll have no problem
> merging from a previous version when we'll decide they're are ready to
> fit in. (let me know)
No, leave them in. I think we have lots of other classes in gdk and
possibly pango which are never used too. (e.g. KeySymbol until a short
time ago)

-- 
  .''`. Mark Howard
 : :' :
 `. `'  http://www.tildemh.com 
   `-   mh...@de... | mh...@ti... | mh...@ca...