[java-gnome-hackers] Fwd: Style schemes for GtkSourceview

[Guillaume M. <res...@gm...>]

---------- Forwarded message ----------
From: cyber python <cyb...@gm...>
Date: 2012/2/6
Subject: Re: [java-gnome-hackers] Style schemes for GtkSourceview
To: Guillaume Mazoyer <res...@gm...>


I think I've got it right this time. See the attachment for the patch.

On Mon, Feb 6, 2012 at 1:38 PM, Guillaume Mazoyer <res...@gm...> wrote:
> This patch looks ok to me.
> Just a couple of things that you could fix easily.
>
> 1. re-run the code formatter (some javadoc comments are not well indented)
> 2. for the classes where you do not define a public constructor maybe
> you should make the default constructor "private" to avoid someone to
> do "new Something()".
>
> Once these things fixed, the patch would be mergeable :)
>
> --
> Guillaume Mazoyer - http://respawner.fr/
>
> ------------------------------------------------------------------------------
> Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> _______________________________________________
> java-gnome-hackers mailing list
> jav...@li...
> https://lists.sourceforge.net/lists/listinfo/java-gnome-hackers


-- 
Guillaume Mazoyer - http://respawner.fr/