Re: [java-gnome-hackers] Style schemes for GtkSourceview
Brought to you by:
afcowie
From: Guillaume M. <res...@gm...> - 2012-02-06 11:38:58
|
This patch looks ok to me. Just a couple of things that you could fix easily. 1. re-run the code formatter (some javadoc comments are not well indented) 2. for the classes where you do not define a public constructor maybe you should make the default constructor "private" to avoid someone to do "new Something()". Once these things fixed, the patch would be mergeable :) -- Guillaume Mazoyer - http://respawner.fr/ |