Re: [java-gnome-hackers] Rewrite of Code generator using GIR (Using GIR as basis)
Brought to you by:
afcowie
From: Andrew C. <an...@op...> - 2010-10-06 17:18:58
|
On Sun, 2010-10-03 at 09:32 +0300, Serkan Kaba wrote: > >> Forgot attaching the patch, here it is. > > > > This isn't a bundle, so we can't create a Bazaar branch from it. Do you > > have this uploaded somewhere? > Here's a bundle Hm. So something seems to have gone way off the rails here. Your bundle removes a ton of .defs files [which makes me nervous, because lots of those files contain a lot of improvements like which classes are deprecated and return types and occasional customizations that were necessary to make java-gnome work at all] but fine, and then, it introduces a huge number of public stubs. Ok, new types, great! Until I noticed you adding org.gnome.gtk.CList. What! That's been deprecated since GTK 1.2; java-gnome goes to a lot of trouble to not expose things like that. There are quite a number of other things there that are longs since discarded. As you know, we've spent a lot of effort over the past 4 years trying to make our public API clean and not present meaningless or obsolete classes. I'm not sure what you doing that required you to add stubs for all these types, but clearly we should not be generating code for them. I assume what happened is that you just ran the generator and produced code for everything ever in GTK. I'm not sure where to go from here. AfC Montreal |