Re: [java-gnome-hackers] ABI break; API bump?

[Andrew C. <an...@op...>]

On Thu, 2009-08-20 at 13:58 +0200, Guillaume Mazoyer wrote:

> I did some changes (the ones we talk on IRC) on my GTK 2.16 entry branch

Nice!

I did a pass over ExampleShowSomeone; I did do some minor comment
cleanup. See 'hackers/andrew/entry-icon'.

I think that example needs to use a TreeModelFilter rather than the
manual clear & repopulate you're doing now, but that doesn't matter
enough for me to block your branch.

One last thing, though: were you planning on *using* the Snapshots you
created? I think you need to add <img> to the Entry.java class javadoc
comment :)

Your branch is otherwise fine and will be merged to 'mainline'. If you
can just maybe do that one thing for the docs, that'd be great.

Cheers,

AfC
Sydney