Re: [java-gnome-hackers] GtkLinkButton covarage
Brought to you by:
afcowie
From: Andrew C. <an...@op...> - 2009-06-17 23:54:30
|
On Wed, 2009-06-17 at 20:55 +0300, Serkan Kaba wrote: > 1) Should I use java.net.URI Yeah, I think so. Early on we chose that path when we did up FileChooser{,Button}'s getURI(). Seems to have been the right decision. > 2) should I use isVisisted or getVisisted for the boolean property > getter. After a find operation in Eclipse I saw that both isProp and > getProp is used for boolean getters. We had a good discussion about that a few years ago. People seemed to feel that having a consistent (and balanced with set) completion space on get<COMPLETE> was best for discoverability — at least so far as "properties" (and property like things) are concerned. So that's mostly what we do. [wow. We really blew it on Entry's 'visibility' property. :) I think I'll patch that and mark the old one deprecated] It looks like certain underlying functions that are asking about state (as opposed to a "property") — gdk_window_is_viewable(), for example was exposed as isViewable() — are exposed with is. Somehow that seems ok. {shrug} So, given that your 'visited' is a GObject property, I think I'd continue with a getVisited(). AfC Sydney |