Re: [java-gnome-hackers] sourceview development branch

[Andrew C. <an...@op...>]

On Wed, 2009-05-20 at 22:45 +0200, Stefan Schweizer wrote:
> I made good progress with that branch over the last days and it would be
> nice if somebody could review it in more detail.

I glanced at it early yesterday and I was quite impressed. It already
seems close to being mergeable which is awesome.

The broader question is whether the API being presented is wise. Because
I'm not [needing to] use this personally it's harder for me to say.

The only thing that really caught my eye so far was
LanguageManager.getDefault(); my *personal* taste is that I dislike
static functions anywhere other than library initialization.

        [I find that in the midst of a whole bunch of instance variable
        usage that they seem out of place. This is why a)
        Screen.getDefault() is still quiet and b) various functions are
        exposed as static methods on classes Glib, Gtk, and Glade]

But a function is a function and this probably the best way to expose
it. I welcome anyone to suggest alternative ideas.

Other than that, my first impression is that this looks great. I'll pull
your latest work later today I'll have a proper review then, but we will
definitely feature this in 4.0.12 :)

AfC
Sydney