Re: [java-gnome-hackers] Little java-gnome contribution

[Andrew C. <an...@op...>]

Vreixo,

On Fri, 2009-05-15 at 09:24 +0000, Vreixo Formoso Lopes wrote:
> ... Attached bundle is a
> little contribution with several changes ... 
> They correspond to an old branch dedicated to add coverage I needed for
> my chart plot application.

Merged to 'mainline'.

> Anyway, it is nice to contribute again to the project.

It's great to hear from you!

++

Everyone,

Branches of code that don't need architectural discussion or design
review are best submitted by direct email [as this was] or by informing
the maintainer of a branch URL to pull. Unless the code needs discussion
it doesn't seem necessary to clutter the list with bundles. They are,
after all, mostly just a transport.[*]

But once in a while I like to take a moment to publicly acknowledge
people's work, especially when we haven't heard from someone in a while.
So that's all this email was.

There's nothing requiring this, however, and I'm aware that some people
seem to think that code only gets merged if they see an email here.

This is not the case. Often I just merge contributions and call it a
day. If I happen to see the contributor on IRC at the time, then I
usually take the trouble to let them know. But in the end, that's
unnecessary and secondary because the Bazaar history shows it.

So please don't feel bad if the maintainer doesn't write here saying he
merged your branch :)

AfC
Sydney


[*]: if code does need discussion or review, then a diff of the part you
want to talk about + a bundle (or URL) makes a great way to start the
conversation. That way someone else can hack on it if they want to, but
the email focuses on the part that needs input.

-- 
Andrew Frederick Cowie

Operational Dynamics is an operations and engineering consultancy
focusing on IT strategy, organizational architecture, systems
review, and effective procedures for change management: enabling
successful deployment of mission critical information technology in
enterprises, worldwide.

http://www.operationaldynamics.com/

Sydney   New York   Toronto   London