Re: [java-gnome-hackers] Libnotify branch

[Andrew C. <an...@op...>]

On Sun, 2009-04-05 at 19:19 +0300, Serkan Kaba wrote:
> I started working on covering libnotify


Outstanding.

> finally the coverage is just enough to be
> usable (can create and display) notifications.

This branch is already acceptable for merging style-wise, which is
excellent. A few minor notes:

An Example demonstrating [how to use] this functionality would not go
amiss...

You've added libnotify to the build script; you'll need to add probes
for it to the top level configure file.

Files newly created and not obviously copying from something existing
can simply be (c) 2009.

When writing documentation, _what_ something does is nice, but _when_
and _why_ you would [or would not] use something is really what needs to
be explained... if you know, of course (and since we really shouldn't be
exposing something if we don't know, most of the time we can do this).

> ideas, especially on org.gnome.notify.Notify and its inheritance.

I'll check that part closely tomorrow, but my first impression reviewing
the diff was that everything is on the right track.

AfC
Sydney

-- 
Andrew Frederick Cowie

Operational Dynamics is an operations and engineering consultancy
focusing on IT strategy, organizational architecture, systems
review, and effective procedures for change management: enabling
successful deployment of mission critical information technology in
enterprises, worldwide.

http://www.operationaldynamics.com/

Sydney   New York   Toronto   London