Re: [java-gnome-hackers] ProgressBar Orientation patch (Need revision)

[Goundy <go...@gm...>]

Hi.

Thank you Afc for your hints I corrected all what you pointed to.
And sorry for the time I put to do it but recently I got really hard 
exams but fortunately I succeeded.
(Two more very easy exams and I'm done :-))

Well I hope this patch is better than the first one.
If there's more changes I should do, just reply back :-)

Thanks and have a good day

Andrew Cowie wrote:
> In the main, your patch is fine. Some QA-ish points:
>
> On Sun, 2009-01-11 at 20:37 +0100, Miloud Bel wrote:
>   
>> - * Copyright (c) 2007-2008 Operational Dynamics Consulting Pty Ltd,
>> and Others
>> + * Copyright (c) 2009 Operational Dynamics Consulting Pty Ltd, and
>> Others
>>     
>
> The correct change is to make it "2007-2009".
>
>   
>> +    /**
>> +     * Set the orientation of the progress bar
>> +     * Four possible values:
>> +     * 
>> +     * LEFT_TO_RIGHT
>> +     * RIGHT_TO_LEFT
>> +     * TOP_TO_BOTTOM
>> +     * BOTTOM_TO_TOP
>>     
>
> If you run javadoc over this (ie, do `make doc`) you will discover that
> whitespace is not preserved (it is, to all intents, HTML) and so you'll
> need to make that an <ul> list or use <br> if you want to have four
> items.
>
> I'm not really sure you need to list them, but whatever.
> http://java-gnome.sourceforge.net/4.0/doc/api/org/gnome/pango/Style.html
> is an example of where we were verbose about it.
>
> You really ought to preview in a web browser. Like I said,
>
> $ make doc
>
>   
>> +     * @param orientation
>> +     *            a ProgressBarOrientation value
>>     
>
> You don't need that.
>
>   
>> +    /**
>> +     * Get the current progress bar orientation
>>     
>
> if you're going to talk about the proper name of a class, then use the
> class name:
>
>         * Get orientation currently in effect in this ProgressBar.
>
> or whatever. Perhaps Kenneth will volunteer to help you with the prose.
>
> ++
>
> You also really need to run the code formatter before committing. Serkan
> can help you with that, but if you're not in Eclipse:
>
> $ make format
>
> and if you are, Source -> Format.
>
> AfC
> Sydney
>
>   
> ------------------------------------------------------------------------
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by:
> SourcForge Community
> SourceForge wants to tell your story.
> http://p.sf.net/sfu/sf-spreadtheword
> ------------------------------------------------------------------------
>
> _______________________________________________
> java-gnome-hackers mailing list
> jav...@li...
> https://lists.sourceforge.net/lists/listinfo/java-gnome-hackers
>