Re: [java-gnome-hackers] More thougths about TreeView and related
Brought to you by:
afcowie
From: Andrew C. <an...@op...> - 2008-03-19 20:18:02
|
On Sun, 2008-03-16 at 18:27 -0300, Vreixo Formoso Lopes wrote: > === modified file 'src/bindings/org/gnome/gtk/TreeIter.java' > --- src/bindings/org/gnome/gtk/TreeIter.java 2008-01-14 03:53:07 > +0000 > +++ src/bindings/org/gnome/gtk/TreeIter.java 2008-03-15 19:18:49 > +0000 ... > + public boolean hasChild() { ... > + public TreeIter children() { ... > + public TreeIter children() { ... Unfortunately TreeIters are not stable first class references. I'll wait to so see what Srichand thinks of this, but I really don't think we should put this stuff on TreeIter. We moved one method only to TreeIter and that was just to make cycling over a model work.* The three methods you are proposing to add above are specialities of TreeStore and really do belong there (actually, they are part of the TreeModel interface, so the open question is whether you ever need the hierarchy methods on a model that is not a TreeStore), and not on TreeIter. [* and even that's sketchy: I am hitting a bug this week where a TreeModel is failing to update because I am making changes to something which affects the sort order while looping over a model's data. I should know better] AfC Toronto |