Thread: [java-gnome-hackers] Style schemes for GtkSourceview

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

Hello,

I have just added coverage for style scheme use in GtkSourceView.

In the attachment, you will find the associated patch.

Best regards,
Georgios Migdos.

Hello again,
I would like to ask for some feedback on this patch (do I have to fix
something to have it accepted ?).

Best regards,
Georgios Migdos.

On Wed, Feb 1, 2012 at 4:26 PM, cyber python <cyb...@gm...> wrote:
> Hello,
>
> I have just added coverage for style scheme use in GtkSourceView.
>
> In the attachment, you will find the associated patch.
>
> Best regards,
> Georgios Migdos.

This patch looks ok to me.
Just a couple of things that you could fix easily.

1. re-run the code formatter (some javadoc comments are not well indented)
2. for the classes where you do not define a public constructor maybe
you should make the default constructor "private" to avoid someone to
do "new Something()".

Once these things fixed, the patch would be mergeable :)

-- 
Guillaume Mazoyer - http://respawner.fr/

---------- Forwarded message ----------
From: cyber python <cyb...@gm...>
Date: 2012/2/6
Subject: Re: [java-gnome-hackers] Style schemes for GtkSourceview
To: Guillaume Mazoyer <res...@gm...>

I think I've got it right this time. See the attachment for the patch.

On Mon, Feb 6, 2012 at 1:38 PM, Guillaume Mazoyer <res...@gm...> wrote:
> This patch looks ok to me.
> Just a couple of things that you could fix easily.
>
> 1. re-run the code formatter (some javadoc comments are not well indented)
> 2. for the classes where you do not define a public constructor maybe
> you should make the default constructor "private" to avoid someone to
> do "new Something()".
>
> Once these things fixed, the patch would be mergeable :)
>
> --
> Guillaume Mazoyer - http://respawner.fr/
>
> ------------------------------------------------------------------------------
> Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> _______________________________________________
> java-gnome-hackers mailing list
> jav...@li...
> https://lists.sourceforge.net/lists/listinfo/java-gnome-hackers

-- 
Guillaume Mazoyer - http://respawner.fr/

Here is the patch that I would actually propose.

-- 
Guillaume Mazoyer - http://respawner.fr/

On Tue, 2012-02-07 at 05:09 +0100, Guillaume Mazoyer wrote:
> Here is the patch that I would actually propose.

Merged to 'mainline'

AfC
Sydney

On 02/13/2012 02:28 AM, Andrew Cowie wrote:
> On Tue, 2012-02-07 at 05:09 +0100, Guillaume Mazoyer wrote:
>> Here is the patch that I would actually propose.
> Merged to 'mainline'
>
> AfC
> Sydney
Hello everyone! I was browsing through the code in mainline ( 
http://research.operationaldynamics.com/bzr/java-gnome/mainline/src ) 
using the web interface and it seems that the patch has not been applied.

On Tue, 2012-04-03 at 23:03 +0300, Georgios Migdos wrote:
> > Merged to 'mainline'
> > 

And so it was; if you'd done

$ bzr missing --line bzr://research.operationaldynamics.com/bzr/java-gnome/mainline/

you'd have seen your patch was there.

In this case, sorry, after pushing I have to manually do `bzr update` on
the working copy checkout on that server; `bzr push` doesn't do that
automatically [which I find annoying, alas]. Sometimes I haven't quite
managed to get around to it. Thanks for checking.

AfC
Sydney

On 04/04/2012 06:26 PM, Andrew Cowie wrote:
> On Tue, 2012-04-03 at 23:03 +0300, Georgios Migdos wrote:
>>> Merged to 'mainline'
>>>
> And so it was; if you'd done
>
> $ bzr missing --line bzr://research.operationaldynamics.com/bzr/java-gnome/mainline/
>
> you'd have seen your patch was there.
>
> In this case, sorry, after pushing I have to manually do `bzr update` on
> the working copy checkout on that server; `bzr push` doesn't do that
> automatically [which I find annoying, alas]. Sometimes I haven't quite
> managed to get around to it. Thanks for checking.
>
> AfC
> Sydney
>
>
>
> ------------------------------------------------------------------------------
> Better than sec? Nothing is better than sec when it comes to
> monitoring Big Data applications. Try Boundary one-second
> resolution app monitoring today. Free.
> http://p.sf.net/sfu/Boundary-dev2dev
> _______________________________________________
> java-gnome-hackers mailing list
> jav...@li...
> https://lists.sourceforge.net/lists/listinfo/java-gnome-hackers
Thanks for the quick reply!