java-gnome-hackers

[java-gnome-hackers] Patch for Cairo Filter constants and Pattern.setFilter(Filter)

[William T. <wil...@gm...>]

Hi -

I've attached a patch which adds The Pattern.setFilter(Filter) method
to the Cairo bindings, plus the requisite Filter constants.
I hope this will be good enough for inclusion. Please let me know if
there are any problems.

This patch makes it possible to specify the interpolation method used
when rendering embedded images in PDFs. This fixes the particular
issue I was having with low resolution PNGs being interpolated and
blurred.
see:
http://cairographics.org/manual/cairo-cairo-pattern-t.html#cairo-pattern-set-filter

Thanks to Andrew Cowie and Adrian Johnson for pointers here.

Best regards,

Will Temperley

Re: [java-gnome-hackers] Patch for Cairo Filter constants and Pattern.setFilter(Filter)

[Guillaume M. <res...@gm...>]

Looks good for me.
Just one thing, maybe you could add some @since tag for the javadoc.

-- 
Guillaume Mazoyer - http://www.respawner.fr/

Re: [java-gnome-hackers] Patch for Cairo Filter constants and Pattern.setFilter(Filter)

[William T. <wil...@gm...>]

On 17 June 2011 13:52, Guillaume Mazoyer <res...@gm...> wrote:
> Looks good for me.
> Just one thing, maybe you could add some @since tag for the javadoc.
> --
> Guillaume Mazoyer - http://www.respawner.fr/
>

Added @since tags - patch attached.  I didn't before as it seemed
presumptuous :)

Will.

Re: [java-gnome-hackers] Patch for Cairo Filter constants and Pattern.setFilter(Filter)

[Andrew C. <an...@op...>]

On Fri, 2011-06-17 at 14:52 +0100, William Temperley wrote:
> Added @since tags - patch attached.  I didn't before as it seemed
> presumptuous :)

No, quite the contrary. Saves the maintainer the work. That's a good
thing :)

And more to the point, I want to encourage people to think about what
release they're getting their code into, ie the next one, ie soon!

(Indeed, 4.0.20 and 4.1.1 are imminent)

Will merge.

AfC
Sydney