java-gnome-hackers

[java-gnome-hackers] Covarage of Pixbuf constructor using byte[] and does scaling

[Serkan K. <se...@ge...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The following bundle adds the mentioned cunstroctor but duplicates most
(actually only a single line is changed) of the code from the
non-scaling version.

Can it be added without code duplication, Martin maybe you have an idea
since you introduced its coverage.

Thanks in advance.
- --
Sincerely,
Serkan KABA
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAko+EtcACgkQRh6X64ivZaJiSACeMKPzlBJOvXHz7+wZoeXj6cji
X6QAnRTMBWn4gFQ/qqVHNSE2gfVsQ2Cc
=hZId
-----END PGP SIGNATURE-----

Re: [java-gnome-hackers] Covarage of Pixbuf constructor using byte[] and does scaling

[Serkan K. <se...@ge...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Actually attaching the bundle.

- --
Sincerely,
Serkan KABA
Gentoo Developer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAko+HKYACgkQRh6X64ivZaJH2ACdG55esL8kxgaLtKg2UDDRIPLe
bhIAmwU1TiQiT5t1gmfYMlFnSUKvsv2s
=D4Jr
-----END PGP SIGNATURE-----

Re: [java-gnome-hackers] Covarage of Pixbuf constructor using byte[] and does scaling

[Andrew C. <an...@op...>]

On Sun, 2009-06-21 at 14:42 +0300, Serkan Kaba wrote:
> Actually attaching the bundle.

Serkan and I chatted about this last night on IRC.

Essentially my feedback to him was "yes, duplication is bad, but hacky
attempts to avoid duplication are worse."

So I'll certainly accept this patch.

++

I just looked at gdk_pixbuf_new_from_stream_at_scale() in devhelp, and
noticed that it takes -1 for width and height.

So maybe we can implement both Pixbuf(byte[]) and Pixbuf(byte[], int,
int, boolean) using the same code path, but using

        GdkPixbufOverride.createPixbufFromArrayAtScale(data, -1, -1,
        false);

for the original method?

I looked at the code in GTK's gdk-pixbuf/gdk-pixbuf-io.c, however, and
I'm not actually sure that's a good idea. The at scale code paths do
considerable extra work that we'd want to avoid.

But I thought I'd mention the possibility for you to think about.

AfC
Sydney

Re: [java-gnome-hackers] Covarage of Pixbuf constructor using byte[] and does scaling

[Serkan K. <se...@ge...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Here's a more debuggable *hack* Please review it.

Thanks,
- --
Sincerely,
Serkan KABA
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAko/xy4ACgkQRh6X64ivZaJH+ACePrgVztX4a3XB92o3d8AO5Ywz
tRMAnjx6+TOtCkkp14pDJ17Jqu1Try8x
=LyGn
-----END PGP SIGNATURE-----

Re: [java-gnome-hackers] Covarage of Pixbuf constructor using byte[] and does scaling

[Serkan K. <se...@ge...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Thanks for the review. Here's the new bundle.

- --
Sincerely,
Serkan KABA
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpATdYACgkQRh6X64ivZaIwSgCfZsW/QvOrvKxWZ2mtkJUb5SZL
RCAAn3wor+DERQQPSMXX2PQlWhfiEjS3
=UvDF
-----END PGP SIGNATURE-----

Re: [java-gnome-hackers] Covarage of Pixbuf constructor using byte[] and does scaling

[Andrew C. <an...@op...>]

On Tue, 2009-06-23 at 06:36 +0300, Serkan Kaba wrote:
> Thanks for the review. Here's the new bundle.

Made a few cleanups, then merged to 'mainline'.

AfC
Sydney

Re: [java-gnome-hackers] Covarage of Pixbuf constructor using byte[] and does scaling

[Andrew C. <an...@op...>]

On Mon, 2009-06-22 at 21:02 +0300, Serkan Kaba wrote:
> +	jboolean _scale

That's the other thing I was going to suggest. :)

Go for it!

AfC
Sydney