java-gnome-hackers

[java-gnome-hackers] Enchant RuntimeException

[Serkan K. <se...@ge...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

When requestDict is called for an unexisting dictionary enchant returns
null and we're not checking this so this throws a
RuntimeException("Cannot make a Java proxy for the NULL pointer!") from
org.freedesktop.bindings.Pointer. I think this should cause a checked
exception or return *java null* if we want to mimic what the underlying
library does

So please comment on what to do (I can work on a patch when we decide on
the road to take)
- -- 
Sincerely,
Serkan KABA
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkuWlLcACgkQRh6X64ivZaKWqwCfXJNRXLHGTTXOm3uzepIPdp8D
w1MAn16lV3mcfrx3rBgfbW+Amp+2xolf
=du9k
-----END PGP SIGNATURE-----

Re: [java-gnome-hackers] Enchant RuntimeException

[Serkan K. <se...@ge...>]

Or
c) If we plan to keep the RuntimeException (GtkSpell fails with a
RuntimeException if passed an unexisting Dictionary) then it should
give a meaningful message

2010/3/9 Serkan Kaba <se...@ge...>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> When requestDict is called for an unexisting dictionary enchant returns
> null and we're not checking this so this throws a
> RuntimeException("Cannot make a Java proxy for the NULL pointer!") from
> org.freedesktop.bindings.Pointer. I think this should cause a checked
> exception or return *java null* if we want to mimic what the underlying
> library does
>
> So please comment on what to do (I can work on a patch when we decide on
> the road to take)
> - --
> Sincerely,
> Serkan KABA
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.14 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkuWlLcACgkQRh6X64ivZaKWqwCfXJNRXLHGTTXOm3uzepIPdp8D
> w1MAn16lV3mcfrx3rBgfbW+Amp+2xolf
> =du9k
> -----END PGP SIGNATURE-----
>
> ------------------------------------------------------------------------------
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> java-gnome-hackers mailing list
> jav...@li...
> https://lists.sourceforge.net/lists/listinfo/java-gnome-hackers
>

Re: [java-gnome-hackers] Enchant RuntimeException

[Andrew C. <an...@op...>]

On Tue, 2010-03-09 at 20:34 +0200, Serkan Kaba wrote:
> When requestDict is called for an unexisting dictionary enchant returns
> null and we're not checking this so this throws a
> RuntimeException("Cannot make a Java proxy for the NULL pointer!")

Huh.

Our doc says "Returns null if no suitable dictionary was found."
http://java-gnome.sourceforge.net/4.0/doc/api/org/freedesktop/enchant/Enchant.html#requestDictionary(java.lang.String)
so presumably we should do that.

[adding a checked Exception would be an API change; while that's not
impossible, as usual I'd prefer not to without a compelling reason to]

AfC
Sydney

Re: [java-gnome-hackers] Enchant RuntimeException

[Serkan K. <se...@ge...>]

> Our doc says "Returns null if no suitable dictionary was found."
> http://java-gnome.sourceforge.net/4.0/doc/api/org/freedesktop/enchant/Enchant.html#requestDictionary(java.lang.String)
> so presumably we should do that.
Following this path then. Attaching the bundle

Regards,
Serkan KABA

Re: [java-gnome-hackers] Enchant RuntimeException

[Andrew C. <an...@op...>]

On Wed, 2010-03-10 at 21:31 +0200, Serkan Kaba wrote:
> > Our doc says "Returns null if no suitable dictionary was found."
> > so presumably we should do that.
> Following this path then. Attaching the bundle

Ok. I added a unit test, and merged to 'mainline',

AfC
Sydney