java-gnome-hackers

[java-gnome-hackers] GtkAssistant, forward page callback

[Guillaume M. <res...@gm...>]

Hi,

I'm trying to cover the GtkAssistant forward page callback
(*GtkAssistantPageFunc). I would like to see this work in the 4.0.17
release but I'm stuck with a problem. When I try to use the code that
I've written, an error occurs.

If I understood what the error says, it seems that GTK doesn't know what
to do with a signal that returns a "gint".

I attached a .diff file so that you can see what change I did. I also
wrote a test case. So if you want to see the error, apply the patch and
run the tests.

-- 
Guillaume Mazoyer - http://www.respawner.fr/

Re: [java-gnome-hackers] GtkAssistant, forward page callback

[Guillaume M. <res...@gm...>]

Here is the error / exception thrown:

Encoutered an error at ValidateAssistant.java:152
The following exception was thrown:

   org.gnome.glib.FatalError: (null)-CRITICAL
Don't know what to do with signal return type gint

-- 
Guillaume Mazoyer - http://www.respawner.fr/

Re: [java-gnome-hackers] GtkAssistant, forward page callback

[Andrew C. <an...@op...>]

On Wed, 2010-10-27 at 08:49 +0200, Guillaume Mazoyer wrote:
>    org.gnome.glib.FatalError: (null)-CRITICAL
> Don't know what to do with signal return type gint

That's coming out of our code, src/jni/bindings_java_signal.c line 475

So you need to add G_TYPE_INT¹ there, except that right now 'I' is being
used to mark an enum return. So maybe change that returnType to 'E' or
something, and make 'I' your gint

You'll also need to change the code at line 571. Start there, in fact.

AfC
Granada


¹ but also see
        
        bindings_java_type_lookup() in src/jni/bindings_java_type.c

and
        
        bindings_java_typeToSignature() in  src/jni_bindings_java_util.c

for other handling of GType to Java type conversions. And note that Java
long is GType G_TYPE_INT64

Re: [java-gnome-hackers] GtkAssistant, forward page callback

[Guillaume M. <res...@gm...>]

Fixed. Thank you for your help.

Here is the bundle with the working code :)

-- 
Guillaume Mazoyer - http://www.respawner.fr/

Re: [java-gnome-hackers] GtkAssistant, forward page callback

[Andrew C. <an...@op...>]

On Wed, 2010-10-27 at 18:06 +0200, Guillaume Mazoyer wrote:
> Here is the bundle with the working code :)

Merged (your branch as subsequently discussed on IRC) to 'mainline'.

AfC
Granada