java-gnome-hackers

[java-gnome-hackers] IconView selection methods

[Guillaume M. <res...@gm...>]

Hello,

To suit my needs, I had to implement few methods into the IconView
class. I had:

 * void selectPath(TreePath path)
 * void unselectPath(TreePath path)
 * void selectAll()
 * void unselectAll()

The branch which contains these methods can be found at:
bzr://research.operationaldynamics.com/bzr/java-gnome/hackers/guillaume/icon-view/

-- 
Guillaume Mazoyer - http://www.respawner.fr/

Re: [java-gnome-hackers] IconView selection methods

[Andrew C. <an...@op...>]

On Tue, 2009-12-29 at 19:53 +0100, Guillaume Mazoyer wrote:
> To suit my needs, I had to implement few methods into the IconView

Great. 

Have you got a test case or two? Maybe select a path and then make sure
it actually _is_ selected, something like that?

AfC
Sydney

Re: [java-gnome-hackers] IconView selection methods

[Guillaume M. <res...@gm...>]

Le mercredi 30 décembre 2009 à 12:30 +1100, Andrew Cowie a écrit :
> Have you got a test case or two? Maybe select a path and then make sure
> it actually _is_ selected, something like that?
Now it's done and available in the branch. By the way, I add the
pathIsSelected(TreePath) method to know if a path is selected or not.
I'd rather name this method isSelected(TreePath). What do you think
about that?

-- 
Guillaume Mazoyer - http://www.respawner.fr/

Re: [java-gnome-hackers] IconView selection methods

[Andrew C. <an...@op...>]

On Wed, 2009-12-30 at 13:50 +0100, Guillaume Mazoyer wrote:
> I added the pathIsSelected(TreePath) method to know if a path is selected or not.

Lovely

> I'd rather name this method isSelected(TreePath). What do you think
> about that?

Hm.

a) for boolean property getters we have _not_ used the isXXX()
signature, preferring a useful getXXX() completion space across all
properties.

b) for *questions* we happily use isYYY().

However,

c) unless there's a really good reason, we try to stick to the
algorithmic mapping of the underlying library's naming.

So the question is, is this case a "really good reason"?

I'm not sure, but I agree isSelected() would be nice.

So sure :) go ahead.

There is a gtk_tree_selection_path_is_selected() in addition to the
gtk_icon_view_path_is_selected() you're asking about. If we change one,
we should [expose and] change the other too.

AfC
Sydney