I received a patch from Stefan Prelle with some nice improvements. I was
about to merge it, but one thing that caught my eye.
CellRendererText has an EDITED signal, the prototype for which is:
public void onEdited(CellRendererText source, String path, String newText);
the second argument is what's bothering me: it's a symbolic location
into the backing TreeModel. Stefan wrote a nice little example into the
javadoc, but when I read it I realized that the first thing that one
does with said path is turn it into a TreePath. It strikes me that this
should already have been done for you, and that the signature in our
bindings should be:
public void onEdited(CellRendererText source, TreePath path, String newText);
which would be more in line with signals like TreeView.ROW_ACTIVATED.
[Obviously I am the one normally arguing that we don't change mappings
without a good reason, but this appears to me to be in the
being-strongly-typed category. So I'm not asking if it's "ok", just if
someone knows a reason why the String form would be more useful to
people hooking up to that signal than a TreePath]
AfC
Sydney
|
