java-gnome-hackers

[java-gnome-hackers] org.gnu.gtk.Action

[Luca De R. <pie...@li...>]

I've wrote a bunch of methods:

public class Action extends GObject {
	
	public String getName() {
		return gtk_action_get_name(handle);
	}
	
	public void activate() {
		gtk_action_activate(handle);
	}
	
	public Widget createIcon(IconSize iconSize) {
		return new Widget(gtk_action_create_icon(handle, iconSize.getValue()));
	}
	
	public Widget createMenuItem() {
		return new Widget(gtk_action_create_menu_item(handle));
	}
	
	public Widget createToolItem() {
		return new Widget(gtk_action_create_tool_item(handle));
	}
	
	public void connectProxy(Widget proxy) {
		gtk_action_connect_proxy(handle, proxy.getHandle());
	}
	
	public void disconnectProxy(Widget proxy) {
		gtk_action_disconnect_proxy(handle, proxy.getHandle());
	}
	
	public void connectAccelerator() {
		gtk_action_connect_accelerator(handle);
	}
	
	public void disconnectAccelerator() {
		gtk_action_disconnect_accelerator(handle);
	}
	
	public static org.gnu.glib.Type getType() {
		return new org.gnu.glib.Type(gtk_action_get_type());
	}
	
	/****************************************
	 * BEGINNING OF JNI CODE
	 ****************************************/
	native static final protected int gtk_action_get_type ();
	native static final protected String gtk_action_get_name(int action);
	native static final protected void gtk_action_activate(int action);
	native static final protected int gtk_action_create_icon(int action, int iconSize);
	native static final protected int gtk_action_create_menu_item(int action);
	native static final protected int gtk_action_create_tool_item(int action);
	native static final protected void gtk_action_connect_proxy(int action, int proxy);
	native static final protected void gtk_action_disconnect_proxy(int action, int proxy);
	native static final protected int[] gtk_action_get_proxies(int action);
	native static final protected void gtk_action_connect_accelerator(int action);
	native static final protected void gtk_action_disconnect_accelerator(int action);
	/****************************************
	 * END OF JNI CODE
	 ****************************************/
	
}

I hope to hear that there are only few errors ;)

A couple of questions:

I've left the getProxies method unimplemented, I've seen you are using
List and ArrayList in the ConfClient class, is it the right way to
handle that?

I'm unsure about the constructor; Should it be: 
	public Action(int handle) {
		super(handle);
	}
??

Jeff, thanks for your patience, I hope to do more tomorrow.

-- 
Luca De Rugeriis <pie...@li...>

Re: [java-gnome-hackers] org.gnu.gtk.Action

[Mark H. <mh...@ca...>]

Hi, 
  Documenting these new classes would be *really* useful - especially
for those of us who have never used the c versions.

On Sat, Dec 27, 2003 at 01:12:54AM +0100, Luca De Rugeriis wrote:
> I'm unsure about the constructor; Should it be: 
> 	public Action(int handle) {
> 		super(handle);

This should probably not be public. Methods which take an int handle
should be used only internally by java-gnome - our users should not need
to know about handles and other c things (e.g. memory management). In
some cases, they have to be public (where they are constructed by other
packages, e.g. pango objects being constructed internally from within
gtk package. If this is the case, the javadoc must say that this method
should only be used internally by java-gnome. 

This is probably a case of documentation... but where would you get an
Action object from? 

-- 
  .''`. Mark Howard
 : :' :
 `. `'  http://www.tildemh.com 
   `-   mh...@de... | mh...@ti... | mh...@ca... 

Re: [java-gnome-hackers] org.gnu.gtk.Action

[Luca De R. <pie...@li...>]

Il sab, 2003-12-27 alle 13:57, Mark Howard ha scritto:
> Hi, 
>   Documenting these new classes would be *really* useful - especially
> for those of us who have never used the c versions.
> 
> On Sat, Dec 27, 2003 at 01:12:54AM +0100, Luca De Rugeriis wrote:
> > I'm unsure about the constructor; Should it be: 
> > 	public Action(int handle) {
> > 		super(handle);
> 
> This should probably not be public. Methods which take an int handle
> should be used only internally by java-gnome - our users should not need
> to know about handles and other c things (e.g. memory management). In
> some cases, they have to be public (where they are constructed by other
> packages, e.g. pango objects being constructed internally from within
> gtk package. If this is the case, the javadoc must say that this method
> should only be used internally by java-gnome.
Totally agreed.

> This is probably a case of documentation... but where would you get an
> Action object from? 
The GtkAction struct contains only private members and should not be
accessed directly. (from gtk docs)
I think it means private etc. but I don't know how these objects are
created, if I don't understand the C source I can't figure it out well.
There is no action_new method, or something.

I'll integrate documentation in these new classes asap.
		
-- 
Luca De Rugeriis <pie...@li...>