Menu

#9 RebuilderStream improper check against oldFile length

open
nobody
None
5
2011-10-13
2011-10-13
No

At RebuilderStream:194 the following precaution-check against old-file's length is invalid:
int len = Math.min(delta.getBlockLength(),
(int) (basisFile.length() - ((Offsets) delta).getOldOffset()));

Indeed, the rebuilding SHOULD fail if
( delta.getBlockLength() + delta.getOldOffset() )
falls outside old-file, in order to detect bad reconstruction process
(either due to agorithm bugs or if old-file changes since sigs-generation)

Reported against svn-trunk, rev: 193

Discussion


Log in to post a comment.

MongoDB Logo MongoDB