Re: [Jamwiki-devel] Review Request: branch thkoch_for_review_2013-04-06

[Ryan H. <rya...@gm...>]

Hi Thomas,

These all look very straightforward - feel free to merge to master at 
your leisure, and also merge to 1.3.x as some of them fix potential HTML 
issues.  The only very minor request I have is that if your edit can be 
set to trim trailing whitespace there are a few places where commits 
added extra tabs or space characters at the ends of lines.

Ryan


On 4/6/2013 6:40 AM, Thomas Koch wrote:
> Mostly very small trivial cleanups. The last commit is a step towards changes
> feed with diffs.
>
> 8b5b42d Extract feed entry description creation in separate function
> e862900 use static helper methods url{En|De}codeUtf8
> 0072ee1 remove unused variable
> 033bcf2 access static members statically, not with this.
> dac898d remove some unused java imports
> a3132fc remove unused variable
> 7004e99 HTML fix: input tags were not closed
> a552bec fix missing equals sign after html attribute
> 46beec6 Fix invalid <p> in <span> tag
>
> Please be so kind and review and merge to master.
>
> Regards,
>
> Thomas Koch, http://www.koch.ro
>
> ------------------------------------------------------------------------------
> Minimize network downtime and maximize team effectiveness.
> Reduce network management and security costs.Learn how to hire
> the most talented Cisco Certified professionals. Visit the
> Employer Resources Portal
> http://www.cisco.com/web/learning/employer_resources/index.html
> _______________________________________________
> Jamwiki-devel mailing list
> Jam...@li...
> https://lists.sourceforge.net/lists/listinfo/jamwiki-devel
>