[Jamwiki-devel] git workflow and commit messages

[Thomas K. <th...@ko...>]

Hi Ryan,

I just saw 3 new commits on the 1.3.x branch and was a bit puzzled not to also 
see them in master. First I wanted to complain but then I first read the 
manpage on gitworkflows[1]. So you did it perfectly correct and I'm just used 
to a workflow that only applies for internal web projects without old versions 
that still need maintenance.

[1] https://www.kernel.org/pub/software/scm/git/docs/gitworkflows.html

Just one nit-picking: Could you please use the first line in commit messages 
for a short summary? That's a generally followed standard. Many tools only 
show the first commit message line for a quick overview and it's not that 
informative to just read "Bugfix:" there.

A search for "commit message" reveals the guidelines of different projects. 
The linux kernel guidelines is found in [2] in section 15.

[2] https://www.kernel.org/doc/Documentation/SubmittingPatches

Two more often cited and good texts on git commit messages:
https://wiki.openstack.org/wiki/GitCommitMessages
http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

I'll review my own patches now for that and push them in a separate branch for 
review and merge.

Regards,

Thomas Koch, http://www.koch.ro