Thread: [Jamwiki-devel] Integrate RankingAlgorithm with JAMWiki as an optional search engine
Brought to you by:
wrh2
From: <jam...@li...> - 2011-01-27 16:45:01
|
Hi! I have integrated RankingAlgorithm ver 1.0 with JAMWiki 1.0 code base, as the default search engine. The admin user can actually configure either Lucene or RankingAlgorithm as the search engine using the admin configuration gui page. I have documented the work in a case study available at http://rankingalgorithm.tgels.com/wiki/en/Case_Study. You can actually try out integration by searching the JAMWiki here: http://rankingalgorithm.tgels.com/wiki. I would like to integrate the source into the JAMWiki trunk. Is it possible to know who I contact on how to go about doing this ? Is there a person that I need to work with who can review this ? Sincerely, - Nagendra Nagarajayya rankingalgorithm.tgels.com |
From: <jam...@li...> - 2011-01-27 17:18:59
|
Hi Nagendra, If you would like to create a branch in the JAMWiki Subversion repository and commit your work then it can definitely be considered for inclusion in an upcoming JAMWiki release. I would need your Sourceforge ID in order to grant you Subversion access. See http://jamwiki.org/wiki/en/How_to_Help for additional details. Note that given its ubiquity and long development history I think that Lucene should remain the default for at least the near future, although the second approach that you outlined of implementing RankingAlgorithm as an alternate SearchEngine would seem like a nice way to provide users with a choice of implementations. If you have any questions, concerns, or further thoughts please forward them on to this list. Cheers, Ryan On 1/27/2011 8:45 AM, jam...@li... wrote: > Hi! > > I have integrated RankingAlgorithm ver 1.0 with JAMWiki 1.0 code base, > as the default search engine. The admin user can actually configure either > Lucene or RankingAlgorithm as the search engine using the > admin configuration gui page. I have documented the work in > a case study available at > http://rankingalgorithm.tgels.com/wiki/en/Case_Study. > You can actually try out integration by searching the JAMWiki here: > http://rankingalgorithm.tgels.com/wiki. > > I would like to integrate the source into the JAMWiki trunk. Is > it possible to know who I contact on how to go about doing this ? > Is there a person that I need to work with who can review this ? > > Sincerely, > > - Nagendra Nagarajayya > rankingalgorithm.tgels.com > > > > ------------------------------------------------------------------------------ > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > > > > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel |
From: <jam...@li...> - 2011-01-28 01:51:13
|
Thanks Ryan! A branch should be fine. My sourceforge id is nnagarajayya and display name is tgels. I can make Lucene as the default SearchEngine. The current implementation is as below and allows either Lucene Search Engine or the RankingAlgorithm Search Engine to be configured as the current search engine through the admin configuration gui. I do have some questions about the changes and the different files that need to be updated (there seem to a lots of properties files for different languages). As of now all my changes are for just one language(default en). Do I send these across to the list ? Regards, - NN On 1/27/2011 9:18 AM, jam...@li... wrote: > Hi Nagendra, > > If you would like to create a branch in the JAMWiki Subversion > repository and commit your work then it can definitely be considered for > inclusion in an upcoming JAMWiki release. I would need your Sourceforge > ID in order to grant you Subversion access. See > http://jamwiki.org/wiki/en/How_to_Help for additional details. > > Note that given its ubiquity and long development history I think that > Lucene should remain the default for at least the near future, although > the second approach that you outlined of implementing RankingAlgorithm > as an alternate SearchEngine would seem like a nice way to provide users > with a choice of implementations. > > If you have any questions, concerns, or further thoughts please forward > them on to this list. > > Cheers, > > Ryan > > > On 1/27/2011 8:45 AM, jam...@li... wrote: >> Hi! >> >> I have integrated RankingAlgorithm ver 1.0 with JAMWiki 1.0 code base, >> as the default search engine. The admin user can actually configure either >> Lucene or RankingAlgorithm as the search engine using the >> admin configuration gui page. I have documented the work in >> a case study available at >> http://rankingalgorithm.tgels.com/wiki/en/Case_Study. >> You can actually try out integration by searching the JAMWiki here: >> http://rankingalgorithm.tgels.com/wiki. >> >> I would like to integrate the source into the JAMWiki trunk. Is >> it possible to know who I contact on how to go about doing this ? >> Is there a person that I need to work with who can review this ? >> >> Sincerely, >> >> - Nagendra Nagarajayya >> rankingalgorithm.tgels.com >> >> >> >> ------------------------------------------------------------------------------ >> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! >> Finally, a world-class log management solution at an even better price-free! >> Download using promo code Free_Logger_4_Dev2Dev. Offer expires >> February 28th, so secure your free ArcSight Logger TODAY! >> http://p.sf.net/sfu/arcsight-sfd2d >> >> >> >> _______________________________________________ >> Jamwiki-devel mailing list >> Jam...@li... >> https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > ------------------------------------------------------------------------------ > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > > |
From: <jam...@li...> - 2011-01-28 04:33:09
|
Hi Nagendra, I've added you to the developers group for JAMWiki, so you should now be able to create a Subversion branch. One important note - I didn't see any license information on the RankingAlgorithm site, although there are a few places that mention that the technology is patent pending, so be aware that all JAMWiki contributions must be licensed LGPL. As to your questions about translations, any translations can be done in English only and committed directly to Subversion (no need to send anything to this list). I'll keep an eye on Subversion commits, but if there's something specific that you want reviewed please send a feedback request to this list. Thanks for contributing! Ryan On 1/27/2011 5:51 PM, jam...@li... wrote: > Thanks Ryan! > > A branch should be fine. My sourceforge id is nnagarajayya and display > name is tgels. > > I can make Lucene as the default SearchEngine. The current implementation is > as below and allows either Lucene Search Engine or the RankingAlgorithm > Search Engine > to be configured as the current search engine through the admin > configuration gui. > > I do have some questions about the changes and the different files that > need to > be updated (there seem to a lots of properties files for different > languages). As > of now all my changes are for just one language(default en). Do I send > these > across to the list ? > > Regards, > - NN |
From: <jam...@li...> - 2011-01-28 15:48:40
|
Hi Ryan: Unfortunately, this library is not released as LGPL but has its own license but is completely free for open source and non-profits projects. Can this be included in binary form only (there seems to be a classpath exception to LGPL 2.1) ? Regards, - NN On 1/27/2011 8:32 PM, jam...@li... wrote: > Hi Nagendra, > > I've added you to the developers group for JAMWiki, so you should now be > able to create a Subversion branch. One important note - I didn't see > any license information on the RankingAlgorithm site, although there are > a few places that mention that the technology is patent pending, so be > aware that all JAMWiki contributions must be licensed LGPL. > > As to your questions about translations, any translations can be done in > English only and committed directly to Subversion (no need to send > anything to this list). I'll keep an eye on Subversion commits, but if > there's something specific that you want reviewed please send a feedback > request to this list. > > Thanks for contributing! > > Ryan > > > On 1/27/2011 5:51 PM, jam...@li... wrote: >> Thanks Ryan! >> >> A branch should be fine. My sourceforge id is nnagarajayya and display >> name is tgels. >> >> I can make Lucene as the default SearchEngine. The current implementation is >> as below and allows either Lucene Search Engine or the RankingAlgorithm >> Search Engine >> to be configured as the current search engine through the admin >> configuration gui. >> >> I do have some questions about the changes and the different files that >> need to >> be updated (there seem to a lots of properties files for different >> languages). As >> of now all my changes are for just one language(default en). Do I send >> these >> across to the list ? >> >> Regards, >> - NN > ------------------------------------------------------------------------------ > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > > |
From: <jam...@li...> - 2011-01-28 16:47:22
|
Hi, If a package isn't released under an LGPL-compatible license then it can't be distributed as part of the JAMWiki package since JAMWiki as a whole is distributed as an LGPL-compatible project. However, if there is interface code for RankingAlgorithm (for example an org.jamwiki.SearchEngine interface) that is LGPL then that can be included in the JAMWiki release, although end users would need to download the RankingAlgorithm binary separately. Let me know if you have any additional questions. Cheers, Ryan On 1/28/2011 7:48 AM, jam...@li... wrote: > Hi Ryan: > > Unfortunately, this library is not released as LGPL but has its own > license but is > completely free for open source and non-profits projects. Can this be > included > in binary form only (there seems to be a classpath exception to LGPL 2.1) ? > > Regards, > - NN > > On 1/27/2011 8:32 PM, jam...@li... wrote: >> Hi Nagendra, >> >> I've added you to the developers group for JAMWiki, so you should now be >> able to create a Subversion branch. One important note - I didn't see >> any license information on the RankingAlgorithm site, although there are >> a few places that mention that the technology is patent pending, so be >> aware that all JAMWiki contributions must be licensed LGPL. >> >> As to your questions about translations, any translations can be done in >> English only and committed directly to Subversion (no need to send >> anything to this list). I'll keep an eye on Subversion commits, but if >> there's something specific that you want reviewed please send a feedback >> request to this list. >> >> Thanks for contributing! >> >> Ryan |
From: <jam...@li...> - 2011-01-29 10:37:50
|
jam...@li... schrieb: > Hi, > > If a package isn't released under an LGPL-compatible license then it > can't be distributed as part of the JAMWiki package since JAMWiki as a > whole is distributed as an LGPL-compatible project. However, if there > is interface code for RankingAlgorithm (for example an > org.jamwiki.SearchEngine interface) that is LGPL then that can be > included in the JAMWiki release, although end users would need to > download the RankingAlgorithm binary separately. Another issue which has to be mentioned. If that lib is not available in any maven repo, it can't be tested automatically. From my pov it would automatically disqualify itself for easy distribution/inclusion. Mike |
From: <jam...@li...> - 2011-01-29 21:27:30
|
Hi Mike: I can make available a dummy (stub) RankingAlgorithm library as LGPL. On a search, it would ask the user to download the real RankingAlgorithm library binary. (The download could be done once by the admin who sets up JAMWiki. Maybe a note in the Readme or Release notes would help) This would enable all tests, etc. to pass as well distribute, etc. Ryan/Mike: Any ideas if this kind of licensing is Ok ? wherein the version distributed has no search functionality, is LGPL but the user downloaded version will have the search, etc. functionalties ... but the license changes to the RankingAlgorithm license. Regards, - NN On 1/29/2011 2:37 AM, jam...@li... wrote: > jam...@li... schrieb: >> Hi, >> >> If a package isn't released under an LGPL-compatible license then it >> can't be distributed as part of the JAMWiki package since JAMWiki as a >> whole is distributed as an LGPL-compatible project. However, if there >> is interface code for RankingAlgorithm (for example an >> org.jamwiki.SearchEngine interface) that is LGPL then that can be >> included in the JAMWiki release, although end users would need to >> download the RankingAlgorithm binary separately. > Another issue which has to be mentioned. If that lib is not available in > any maven repo, it can't be tested automatically. From my pov it would > automatically disqualify itself for easy distribution/inclusion. > > Mike > > ------------------------------------------------------------------------------ > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > > |
From: <jam...@li...> - 2011-01-29 22:19:13
|
jam...@li... schrieb: > Hi Mike: > > I can make available a dummy (stub) RankingAlgorithm library as LGPL. > On a search, it would ask the user to download the real RankingAlgorithm > library binary. > (The download could be done once by the admin who sets up JAMWiki. Maybe > a note in the Readme or Release notes would help) > > This would enable all tests, etc. to pass as well distribute, etc. > > Ryan/Mike: Any ideas if this kind of licensing is Ok ? wherein > the version distributed has no search functionality, is LGPL but the > user downloaded version will have the search, etc. functionalties ... but > the license changes to the RankingAlgorithm license. Hi Nagendra, this would work but it is not desirable and reasonable imho. It would be easier if you would make your lib binary available in Maven Central and create a profile which activates the raking algorith module in addons + an appropriate profile to depend war module on the aforementined one and include an alternative jamwiki-configuration.xml. JAMWiki could be build with your search engine then with a mere "mvn -Dwith-rankingalgorithm". What do you say Ryan? Mike |
From: <jam...@li...> - 2011-01-29 22:43:54
|
> What do you say Ryan? I guess I've got two thoughts: 1. If there are a number of users of RankingAlgorithm out there who want to integrate it with JAMWiki, then including a org.jamwiki.SearchEngine interface that would allow them to run JAMWiki with their existing implementation is a good thing. We do something similar with database support - JAMWiki doesn't care about database licensing so long as the org.jamwiki.DataHandler interface for that database is functional and LGPL. 2. If we're instead simply putting wrappers in place that enable JAMWiki users to select a search interface that is essentially a "click here to download" link, then I'm not sure if that's so useful, and it would probably be better to keep the RankingAlgorithm interface as a separately downloadable plugin for now. Hopefully that's clear - I don't want to distribute a "stub" version of RankingAlgorithm that lacks any functionality, but I'm 100% OK with including an implementation of org.jamwiki.SearchEngine that works for existing users of RankingAlgorithm. Ryan |
From: <jam...@li...> - 2011-01-30 03:51:42
|
Thanks Ryan! I think 1. is a better choice and more elegant than distributing a stub version. Will get started on integrating RankingAlgorithmSearchEngine interface into a branch. As of now, I have the current implementation on the latest version that I retrieved about a week ago. I have the dependency in the main pom.xml along with lucene. Please correct me here, you want me to create a branch and add RankingAlgorithm to the addons module similar to the bliki parser, right ? Regards, - NN On 1/29/2011 2:43 PM, jam...@li... wrote: >> What do you say Ryan? > I guess I've got two thoughts: > > 1. If there are a number of users of RankingAlgorithm out there who want > to integrate it with JAMWiki, then including a org.jamwiki.SearchEngine > interface that would allow them to run JAMWiki with their existing > implementation is a good thing. We do something similar with database > support - JAMWiki doesn't care about database licensing so long as the > org.jamwiki.DataHandler interface for that database is functional and LGPL. > > 2. If we're instead simply putting wrappers in place that enable JAMWiki > users to select a search interface that is essentially a "click here to > download" link, then I'm not sure if that's so useful, and it would > probably be better to keep the RankingAlgorithm interface as a > separately downloadable plugin for now. > > Hopefully that's clear - I don't want to distribute a "stub" version of > RankingAlgorithm that lacks any functionality, but I'm 100% OK with > including an implementation of org.jamwiki.SearchEngine that works for > existing users of RankingAlgorithm. > > Ryan > > > > ------------------------------------------------------------------------------ > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > > |
From: <jam...@li...> - 2011-02-01 15:44:46
|
> Please correct me here, you want me to create a branch and add > RankingAlgorithm to the addons module similar to the bliki parser, right ? Sorry for not responding sooner. Yes, if you follow the Bliki example and can do it in a way that doesn't force a dependency on RankingAlgorithm being included in the JAMWiki distribution then it should be fine. I'll keep an eye on any commits you make and will try to provide prompt feedback, although I'm out of town for work currently and my hotel does not have good internet access so responses may be a bit slower than normal. Ryan |
From: <jam...@li...> - 2011-02-01 16:47:03
|
Thanks Ryan! Will start looking at integrating this. Regards, - NN On 2/1/2011 7:44 AM, jam...@li... wrote: >> Please correct me here, you want me to create a branch and add >> RankingAlgorithm to the addons module similar to the bliki parser, right ? > Sorry for not responding sooner. Yes, if you follow the Bliki example > and can do it in a way that doesn't force a dependency on > RankingAlgorithm being included in the JAMWiki distribution then it > should be fine. I'll keep an eye on any commits you make and will try > to provide prompt feedback, although I'm out of town for work currently > and my hotel does not have good internet access so responses may be a > bit slower than normal. > > Ryan > > ------------------------------------------------------------------------------ > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > > |
From: <jam...@li...> - 2011-02-09 16:15:04
|
Hi Ryan: I have this working now. it works a little differently than below since all we need is the rankingalgorithm.jar to be available in the jamwiki repository. The rankingalgorithm.jar is needed for compilation, etc. to resolve linkage issues. At war build time, I have an exclude so that the rankingalgorithm.jar is not included in the war file being built. This avoids it being part of the JAMWiki distribution. After deploy, the admin can configure the RankingAlgorithm as the search engine. At save this throws up an exception that RankingAglorithm class file not found and the admin would need to copy the rankingalgorithm jar file to the WEB/lib directory. Is there someplace this could be documented on what the admin has to do ? I will go ahead and create a branch and add the new code. Regards, - NN On 2/1/2011 7:44 AM, jam...@li... wrote: >> Please correct me here, you want me to create a branch and add >> RankingAlgorithm to the addons module similar to the bliki parser, right ? > Sorry for not responding sooner. Yes, if you follow the Bliki example > and can do it in a way that doesn't force a dependency on > RankingAlgorithm being included in the JAMWiki distribution then it > should be fine. I'll keep an eye on any commits you make and will try > to provide prompt feedback, although I'm out of town for work currently > and my hotel does not have good internet access so responses may be a > bit slower than normal. > > Ryan > > ------------------------------------------------------------------------------ > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > > |
From: <jam...@li...> - 2011-02-09 17:15:04
|
jam...@li... schrieb: > Hi Ryan: > > I have this working now. it works a little differently than below since > all we need is the > rankingalgorithm.jar to be available in the jamwiki repository. The > rankingalgorithm.jar > is needed for compilation, etc. to resolve linkage issues. At war build > time, I have > an exclude so that the rankingalgorithm.jar is not included in the war > file being built. > This avoids it being part of the JAMWiki distribution. > > After deploy, the admin can configure the RankingAlgorithm as the search > engine. > At save this throws up an exception that RankingAglorithm class file not > found and > the admin would need to copy the rankingalgorithm jar file to the > WEB/lib directory. > Is there someplace this could be documented on what the admin has to do ? > > I will go ahead and create a branch and add the new code. Hi, please consider that the ranking algo jar has to be available in a publicly accessible repo. There is no jamwiki repo. Either you host your on repo or get a hosted one at sonatype OSS. The best solution for inclusion would be, as I have mentioned before, a profile which would activate the addon module AND the dependency to it. Mike |
From: <jam...@li...> - 2011-02-09 17:46:36
|
> The best solution for inclusion would be, as I have mentioned before, a > profile which would activate the addon module AND the dependency to it. Just to concur with Mike, there can't be any dependencies in JAMWiki (including in the source code repository) that require code that isn't LGPL-compatible. It's perfectly OK to build a LGPL interface to allow use of proprietary code (as we do currently with the DataHandler implementations), but that proprietary code can't live in the JAMWiki repository and can't be a requirement for anyone building JAMWiki. Licensing issues can be messy, so I very much want to avoid getting into any gray areas that could present any legal issues. Additionally, licensing is a moral issue for many developers, and I want to ensure that developers aren't deterred from contributing over licensing concerns. Ryan |
From: <jam...@li...> - 2011-02-11 16:30:44
|
Thanks Ryan/Mike! I have this working now. There are no dependencies on rankingalgorithm30.jar now. The only code needed is the LGPL interface RankingAlgorithmSearchEngine.java. This change makes this simpler since there is just one new file and some simple changes/additions to SearchEngine.java, ApplicationResource.properties, jamwiki-configuration.xml, search-results.jsp. There is no exception when RankingAlgorithm is set as the default library without rankingalgorithm30.jar being in the classpath by the admin. The only thing that might be needed is an error when a user searches without the rankingalgorith30.jar, as the results come back empty with the message topic not found. JAMwiki also needs to be restarted to read the indexes. I think this maybe overcome, not sure yet. Regards, - NN On 2/9/2011 9:46 AM, jam...@li... wrote: >> The best solution for inclusion would be, as I have mentioned before, a >> profile which would activate the addon module AND the dependency to it. > Just to concur with Mike, there can't be any dependencies in JAMWiki > (including in the source code repository) that require code that isn't > LGPL-compatible. It's perfectly OK to build a LGPL interface to allow > use of proprietary code (as we do currently with the DataHandler > implementations), but that proprietary code can't live in the JAMWiki > repository and can't be a requirement for anyone building JAMWiki. > > Licensing issues can be messy, so I very much want to avoid getting into > any gray areas that could present any legal issues. Additionally, > licensing is a moral issue for many developers, and I want to ensure > that developers aren't deterred from contributing over licensing concerns. > > Ryan > > ------------------------------------------------------------------------------ > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > > |
From: <jam...@li...> - 2011-02-12 20:42:22
|
Hi Ryan/Mike: I have this working of a new branch on 1.1 code base. I have added a new property to ApplicationResources.properties, admin.searchengine.rankingalgorithm=RankingAlgorithm Search Engine Do I need to add this to all the translated language resource bundles ? Does the code by default load the default en resource bundle and then load the language bundles to get the translations ? Regards, - NN On 2/11/2011 8:30 AM, jam...@li... wrote: > Thanks Ryan/Mike! > > I have this working now. There are no dependencies on > rankingalgorithm30.jar now. The only > code needed is the LGPL interface RankingAlgorithmSearchEngine.java. > This change > makes this simpler since there is just one new file and some simple > changes/additions > to SearchEngine.java, ApplicationResource.properties, > jamwiki-configuration.xml, > search-results.jsp. > > There is no exception when RankingAlgorithm is set as the default > library without > rankingalgorithm30.jar being in the classpath by the admin. The only > thing that might > be needed is an error when a user searches without the > rankingalgorith30.jar, > as the results come back empty with the message topic not found. > JAMwiki also needs to be restarted to read the indexes. I think this > maybe > overcome, not sure yet. > > Regards, > - NN > > On 2/9/2011 9:46 AM, jam...@li... wrote: >>> The best solution for inclusion would be, as I have mentioned before, a >>> profile which would activate the addon module AND the dependency to it. >> Just to concur with Mike, there can't be any dependencies in JAMWiki >> (including in the source code repository) that require code that isn't >> LGPL-compatible. It's perfectly OK to build a LGPL interface to allow >> use of proprietary code (as we do currently with the DataHandler >> implementations), but that proprietary code can't live in the JAMWiki >> repository and can't be a requirement for anyone building JAMWiki. >> >> Licensing issues can be messy, so I very much want to avoid getting into >> any gray areas that could present any legal issues. Additionally, >> licensing is a moral issue for many developers, and I want to ensure >> that developers aren't deterred from contributing over licensing concerns. >> >> Ryan >> >> ------------------------------------------------------------------------------ >> The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: >> Pinpoint memory and threading errors before they happen. >> Find and fix more than 250 security defects in the development cycle. >> Locate bottlenecks in serial and parallel code that limit performance. >> http://p.sf.net/sfu/intel-dev2devfeb >> _______________________________________________ >> Jamwiki-devel mailing list >> Jam...@li... >> https://lists.sourceforge.net/lists/listinfo/jamwiki-devel >> >> > > > ------------------------------------------------------------------------------ > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > > > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel |
From: <jam...@li...> - 2011-02-13 06:00:04
|
Hi, Translations are only necessary for the ApplicationResources.properties file - if a language-specific translation does not exist it defaults to the value from ApplicationResources.properties. I haven't yet had a chance to look at your code but will do so soon. One important note - in the future it would be best to create a branch, commit it, and then commit any changes in order to make reviewing easier. That approach allows the change commit to be reviewed, rather than necessitating a diff against the trunk to find files that have changed. Thanks! Ryan On 2/12/2011 12:42 PM, jam...@li... wrote: > Hi Ryan/Mike: > > I have this working of a new branch on 1.1 code base. I have added a new > property > to ApplicationResources.properties, > admin.searchengine.rankingalgorithm=RankingAlgorithm Search Engine > > Do I need to add this to all the translated language resource bundles ? > Does the code by default load the default en resource bundle and then > load the language bundles to get the translations ? > > Regards, > - NN |
From: <jam...@li...> - 2011-02-13 15:06:54
|
Thanks Ryan! Will try to see if I can commit each functional change as below. - NN On 2/12/2011 9:59 PM, jam...@li... wrote: > Hi, > > Translations are only necessary for the ApplicationResources.properties > file - if a language-specific translation does not exist it defaults to > the value from ApplicationResources.properties. > > I haven't yet had a chance to look at your code but will do so soon. > One important note - in the future it would be best to create a branch, > commit it, and then commit any changes in order to make reviewing > easier. That approach allows the change commit to be reviewed, rather > than necessitating a diff against the trunk to find files that have > changed. Thanks! > > Ryan > > > On 2/12/2011 12:42 PM, jam...@li... wrote: >> Hi Ryan/Mike: >> >> I have this working of a new branch on 1.1 code base. I have added a new >> property >> to ApplicationResources.properties, >> admin.searchengine.rankingalgorithm=RankingAlgorithm Search Engine >> >> Do I need to add this to all the translated language resource bundles ? >> Does the code by default load the default en resource bundle and then >> load the language bundles to get the translations ? >> >> Regards, >> - NN > ------------------------------------------------------------------------------ > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > > |
From: <jam...@li...> - 2011-02-15 03:59:55
|
Hi Ryan: I just commit the rankingalgorithm branch, please check revision 3472. Regards, - NN On 2/13/2011 7:06 AM, jam...@li... wrote: > Thanks Ryan! Will try to see if I can commit each functional change as > below. > > - NN > > On 2/12/2011 9:59 PM, jam...@li... wrote: >> Hi, >> >> Translations are only necessary for the ApplicationResources.properties >> file - if a language-specific translation does not exist it defaults to >> the value from ApplicationResources.properties. >> >> I haven't yet had a chance to look at your code but will do so soon. >> One important note - in the future it would be best to create a branch, >> commit it, and then commit any changes in order to make reviewing >> easier. That approach allows the change commit to be reviewed, rather >> than necessitating a diff against the trunk to find files that have >> changed. Thanks! >> >> Ryan >> >> >> On 2/12/2011 12:42 PM, jam...@li... wrote: >>> Hi Ryan/Mike: >>> >>> I have this working of a new branch on 1.1 code base. I have added a new >>> property >>> to ApplicationResources.properties, >>> admin.searchengine.rankingalgorithm=RankingAlgorithm Search Engine >>> >>> Do I need to add this to all the translated language resource bundles ? >>> Does the code by default load the default en resource bundle and then >>> load the language bundles to get the translations ? >>> >>> Regards, >>> - NN >> ------------------------------------------------------------------------------ >> The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: >> Pinpoint memory and threading errors before they happen. >> Find and fix more than 250 security defects in the development cycle. >> Locate bottlenecks in serial and parallel code that limit performance. >> http://p.sf.net/sfu/intel-dev2devfeb >> _______________________________________________ >> Jamwiki-devel mailing list >> Jam...@li... >> https://lists.sourceforge.net/lists/listinfo/jamwiki-devel >> >> > > ------------------------------------------------------------------------------ > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > > |
From: <jam...@li...> - 2011-02-17 13:41:02
|
Hi Ryan: Did you have a chance to look at the commits ? What are the next steps to merge the branch into the main trunk ? Is there something that I need to do ? Regards, - NN On 2/14/2011 7:59 PM, jam...@li... wrote: > Hi Ryan: > > I just commit the rankingalgorithm branch, please check revision 3472. > > Regards, > - NN > > On 2/13/2011 7:06 AM, jam...@li... wrote: >> Thanks Ryan! Will try to see if I can commit each functional change as >> below. >> >> - NN >> >> On 2/12/2011 9:59 PM, jam...@li... wrote: >>> Hi, >>> >>> Translations are only necessary for the ApplicationResources.properties >>> file - if a language-specific translation does not exist it defaults to >>> the value from ApplicationResources.properties. >>> >>> I haven't yet had a chance to look at your code but will do so soon. >>> One important note - in the future it would be best to create a branch, >>> commit it, and then commit any changes in order to make reviewing >>> easier. That approach allows the change commit to be reviewed, rather >>> than necessitating a diff against the trunk to find files that have >>> changed. Thanks! >>> >>> Ryan >>> >>> >>> On 2/12/2011 12:42 PM, jam...@li... wrote: >>>> Hi Ryan/Mike: >>>> >>>> I have this working of a new branch on 1.1 code base. I have added a new >>>> property >>>> to ApplicationResources.properties, >>>> admin.searchengine.rankingalgorithm=RankingAlgorithm Search Engine >>>> >>>> Do I need to add this to all the translated language resource bundles ? >>>> Does the code by default load the default en resource bundle and then >>>> load the language bundles to get the translations ? >>>> >>>> Regards, >>>> - NN >>> ------------------------------------------------------------------------------ >>> The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: >>> Pinpoint memory and threading errors before they happen. >>> Find and fix more than 250 security defects in the development cycle. >>> Locate bottlenecks in serial and parallel code that limit performance. >>> http://p.sf.net/sfu/intel-dev2devfeb >>> _______________________________________________ >>> Jamwiki-devel mailing list >>> Jam...@li... >>> https://lists.sourceforge.net/lists/listinfo/jamwiki-devel >>> >>> >> ------------------------------------------------------------------------------ >> The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: >> Pinpoint memory and threading errors before they happen. >> Find and fix more than 250 security defects in the development cycle. >> Locate bottlenecks in serial and parallel code that limit performance. >> http://p.sf.net/sfu/intel-dev2devfeb >> _______________________________________________ >> Jamwiki-devel mailing list >> Jam...@li... >> https://lists.sourceforge.net/lists/listinfo/jamwiki-devel >> >> > > ------------------------------------------------------------------------------ > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > > |
From: <jam...@li...> - 2011-02-17 13:44:09
|
jam...@li... schrieb: > Hi Ryan: > > Did you have a chance to look at the commits ? What are the next steps to > merge the branch into the main trunk ? Is there something that I need to > do ? Keep your branch in sync with the trunk and prepare to reintegrate your branch into trunk when Ryan thinks fit. Mike |
From: <jam...@li...> - 2011-02-17 15:26:53
|
Sorry for the delay - work is keeping me extremely busy. I haven't yet had a chance to look at the code but will do so by the weekend. Ryan On 2/17/2011 5:41 AM, jam...@li... wrote: > Hi Ryan: > > Did you have a chance to look at the commits ? What are the next steps to > merge the branch into the main trunk ? Is there something that I need to > do ? > > Regards, > - NN |
From: <jam...@li...> - 2011-02-18 03:30:07
|
Hi, One feedback item - it looks RankingAlgorithmSearchEngine has several unused private methods copied from LuceneSearchEngine. Can you remove those methods, and if any private methods from LuceneSearchEngine really are needed in RankingAlgorithmSearchEngine can you just change them to protected in LuceneSearchEngine? Thanks! Ryan On 2/17/2011 5:41 AM, jam...@li... wrote: > Hi Ryan: > > Did you have a chance to look at the commits ? What are the next steps to > merge the branch into the main trunk ? Is there something that I need to > do ? > > Regards, > - NN |