Thread: Re: [Jamwiki-devel] Integrate RankingAlgorithm with JAMWiki as an optional search engine (Page 2)
Brought to you by:
wrh2
From: <jam...@li...> - 2011-02-20 03:25:30
|
Thanks Ryan for taking a look. Only one method findResults is needed in RankingAlgorithmSearchEngine, the rest defaults to LuceneSearchEngine methods. I will change the access modifiers to protected. - NN On 2/17/2011 7:29 PM, jam...@li... wrote: > Hi, > > One feedback item - it looks RankingAlgorithmSearchEngine has several > unused private methods copied from LuceneSearchEngine. Can you remove > those methods, and if any private methods from LuceneSearchEngine really > are needed in RankingAlgorithmSearchEngine can you just change them to > protected in LuceneSearchEngine? Thanks! > > Ryan > > > On 2/17/2011 5:41 AM, jam...@li... wrote: >> Hi Ryan: >> >> Did you have a chance to look at the commits ? What are the next steps to >> merge the branch into the main trunk ? Is there something that I need to >> do ? >> >> Regards, >> - NN > ------------------------------------------------------------------------------ > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > > |
From: <jam...@li...> - 2011-02-20 20:10:33
|
Hi Ryan: I have committed the access modifier changes. Please let me know if it looks Ok. Thanks, - NN On 2/19/2011 7:25 PM, jam...@li... wrote: > Thanks Ryan for taking a look. Only one method findResults is needed in > RankingAlgorithmSearchEngine, > the rest defaults to LuceneSearchEngine methods. I will change the > access modifiers to protected. > > - NN > > On 2/17/2011 7:29 PM, jam...@li... wrote: >> Hi, >> >> One feedback item - it looks RankingAlgorithmSearchEngine has several >> unused private methods copied from LuceneSearchEngine. Can you remove >> those methods, and if any private methods from LuceneSearchEngine really >> are needed in RankingAlgorithmSearchEngine can you just change them to >> protected in LuceneSearchEngine? Thanks! >> >> Ryan >> >> >> On 2/17/2011 5:41 AM, jam...@li... wrote: >>> Hi Ryan: >>> >>> Did you have a chance to look at the commits ? What are the next steps to >>> merge the branch into the main trunk ? Is there something that I need to >>> do ? >>> >>> Regards, >>> - NN >> ------------------------------------------------------------------------------ >> The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: >> Pinpoint memory and threading errors before they happen. >> Find and fix more than 250 security defects in the development cycle. >> Locate bottlenecks in serial and parallel code that limit performance. >> http://p.sf.net/sfu/intel-dev2devfeb >> _______________________________________________ >> Jamwiki-devel mailing list >> Jam...@li... >> https://lists.sourceforge.net/lists/listinfo/jamwiki-devel >> >> > > ------------------------------------------------------------------------------ > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > > |
From: <jam...@li...> - 2011-02-24 05:23:04
|
Hi, I took a look at the latest changes - I'd like to make sure that none of the protected methods in LuceneSearchEngine can remain private, and I'd like to look at some alternatives to hard-coding the searching engine link on the JSPs, but otherwise I didn't immediately see any issues. Hopefully I'll have some free time and this can be merged this weekend. Ryan On 2/20/2011 1:10 PM, jam...@li... wrote: > Hi Ryan: > > I have committed the access modifier changes. Please let me know if it > looks Ok. > > Thanks, > - NN > > On 2/19/2011 7:25 PM, jam...@li... wrote: >> Thanks Ryan for taking a look. Only one method findResults is needed in >> RankingAlgorithmSearchEngine, >> the rest defaults to LuceneSearchEngine methods. I will change the >> access modifiers to protected. >> >> - NN |
From: <jam...@li...> - 2011-02-26 22:17:01
|
Thanks Ryan! Let me know if I need to do anything. I was trying to sync up with the trunk as per Mike's suggestion but ran into some problems. Will try again but if I encounter problems, might need info on how you folks do it. Regards, - NN On 2/23/2011 9:22 PM, jam...@li... wrote: > Hi, > > I took a look at the latest changes - I'd like to make sure that none of > the protected methods in LuceneSearchEngine can remain private, and I'd > like to look at some alternatives to hard-coding the searching engine > link on the JSPs, but otherwise I didn't immediately see any issues. > Hopefully I'll have some free time and this can be merged this weekend. > > Ryan > > > On 2/20/2011 1:10 PM, jam...@li... wrote: >> Hi Ryan: >> >> I have committed the access modifier changes. Please let me know if it >> looks Ok. >> >> Thanks, >> - NN >> >> On 2/19/2011 7:25 PM, jam...@li... wrote: >>> Thanks Ryan for taking a look. Only one method findResults is needed in >>> RankingAlgorithmSearchEngine, >>> the rest defaults to LuceneSearchEngine methods. I will change the >>> access modifiers to protected. >>> >>> - NN > ------------------------------------------------------------------------------ > Free Software Download: Index, Search& Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT data > generated by your applications, servers and devices whether physical, virtual > or in the cloud. Deliver compliance at lower cost and gain new business > insights. http://p.sf.net/sfu/splunk-dev2dev > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > > |
From: <jam...@li...> - 2011-02-27 21:25:26
|
Hi, I've merged the RankingAlgorithm code to trunk with some modifications. Please let me know if you have any questions or concerns. The changes I made were mainly organizational, but if there are any problems feel free to commit a fix. Cheers, Ryan On 2/26/2011 2:17 PM, jam...@li... wrote: > Thanks Ryan! Let me know if I need to do anything. I was trying to sync > up with the trunk as per Mike's suggestion but ran into some problems. > Will try again but if I encounter problems, might need info on how you > folks do it. > > Regards, > - NN > > On 2/23/2011 9:22 PM, jam...@li... wrote: >> Hi, >> >> I took a look at the latest changes - I'd like to make sure that none of >> the protected methods in LuceneSearchEngine can remain private, and I'd >> like to look at some alternatives to hard-coding the searching engine >> link on the JSPs, but otherwise I didn't immediately see any issues. >> Hopefully I'll have some free time and this can be merged this weekend. >> >> Ryan |
From: <jam...@li...> - 2011-02-28 13:52:15
|
Thanks Ryan! This is great. Will check out the merge. Regards, - NN On 2/27/2011 1:25 PM, jam...@li... wrote: > Hi, > > I've merged the RankingAlgorithm code to trunk with some modifications. > Please let me know if you have any questions or concerns. The changes > I made were mainly organizational, but if there are any problems feel > free to commit a fix. > > Cheers, > > Ryan > > > On 2/26/2011 2:17 PM, jam...@li... wrote: >> Thanks Ryan! Let me know if I need to do anything. I was trying to sync >> up with the trunk as per Mike's suggestion but ran into some problems. >> Will try again but if I encounter problems, might need info on how you >> folks do it. >> >> Regards, >> - NN >> >> On 2/23/2011 9:22 PM, jam...@li... wrote: >>> Hi, >>> >>> I took a look at the latest changes - I'd like to make sure that none of >>> the protected methods in LuceneSearchEngine can remain private, and I'd >>> like to look at some alternatives to hard-coding the searching engine >>> link on the JSPs, but otherwise I didn't immediately see any issues. >>> Hopefully I'll have some free time and this can be merged this weekend. >>> >>> Ryan > ------------------------------------------------------------------------------ > Free Software Download: Index, Search& Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT data > generated by your applications, servers and devices whether physical, virtual > or in the cloud. Deliver compliance at lower cost and gain new business > insights. http://p.sf.net/sfu/splunk-dev2dev > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > > |
From: <jam...@li...> - 2011-03-01 04:03:00
|
Hi Ryan: I was testing the new changes, and everything works except that if search.jsp is activated, the Search powered by shows ?????? instead of either "Lucene" or "RankingAlgorithm". This works correctly if search-results.jsp gets activated. Atleast from what I understand, search.jsp seems to get activated if you click on the search button without entering any search terms. Both seem to use the same mechanism to get the resource searchConfig.key2 but in one case this seems to be valid and returns the right value while in the other seems to be out of scope and returns either a null or "????". Regards, - NN On 2/28/2011 5:52 AM, jam...@li... wrote: > Thanks Ryan! This is great. Will check out the merge. > > Regards, > - NN > > On 2/27/2011 1:25 PM, jam...@li... wrote: >> Hi, >> >> I've merged the RankingAlgorithm code to trunk with some modifications. >> Please let me know if you have any questions or concerns. The changes >> I made were mainly organizational, but if there are any problems feel >> free to commit a fix. >> >> Cheers, >> >> Ryan >> >> >> On 2/26/2011 2:17 PM, jam...@li... wrote: >>> Thanks Ryan! Let me know if I need to do anything. I was trying to sync >>> up with the trunk as per Mike's suggestion but ran into some problems. >>> Will try again but if I encounter problems, might need info on how you >>> folks do it. >>> >>> Regards, >>> - NN >>> >>> On 2/23/2011 9:22 PM, jam...@li... wrote: >>>> Hi, >>>> >>>> I took a look at the latest changes - I'd like to make sure that none of >>>> the protected methods in LuceneSearchEngine can remain private, and I'd >>>> like to look at some alternatives to hard-coding the searching engine >>>> link on the JSPs, but otherwise I didn't immediately see any issues. >>>> Hopefully I'll have some free time and this can be merged this weekend. >>>> >>>> Ryan >> ------------------------------------------------------------------------------ >> Free Software Download: Index, Search& Analyze Logs and other IT data in >> Real-Time with Splunk. Collect, index and harness all the fast moving IT data >> generated by your applications, servers and devices whether physical, virtual >> or in the cloud. Deliver compliance at lower cost and gain new business >> insights. http://p.sf.net/sfu/splunk-dev2dev >> _______________________________________________ >> Jamwiki-devel mailing list >> Jam...@li... >> https://lists.sourceforge.net/lists/listinfo/jamwiki-devel >> >> > > ------------------------------------------------------------------------------ > Free Software Download: Index, Search& Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT data > generated by your applications, servers and devices whether physical, virtual > or in the cloud. Deliver compliance at lower cost and gain new business > insights. http://p.sf.net/sfu/splunk-dev2dev > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > > |
From: <jam...@li...> - 2011-03-01 05:38:19
|
Hi, Thanks for the catch - revision 3484 fixes the issue for me locally, but let me know if you still encounter any problems. Ryan On 2/28/2011 8:02 PM, jam...@li... wrote: > Hi Ryan: > > I was testing the new changes, and everything works except that if > search.jsp is activated, the Search powered by shows ?????? instead of > either "Lucene" or "RankingAlgorithm". This works correctly if > search-results.jsp gets activated. Atleast from what I understand, > search.jsp seems to get activated if you click on the search button > without entering any search terms. Both seem to use the same mechanism > to get the resource searchConfig.key2 but in one case this seems to be > valid and returns the right value while in the other seems to be out of > scope and returns either a null or "????". > > Regards, > - NN |
From: <jam...@li...> - 2011-03-02 15:28:41
|
Hi Ryan: I would like to add a menu option to the documentation at http://jamwiki.org/wiki/en/Configuration about being able to configure an alternate search engine, similar to bliki parser, will this be Ok ? Regards, - NN On 2/28/2011 9:38 PM, jam...@li... wrote: > Hi, > > Thanks for the catch - revision 3484 fixes the issue for me locally, but > let me know if you still encounter any problems. > > Ryan > > > On 2/28/2011 8:02 PM, jam...@li... wrote: >> Hi Ryan: >> >> I was testing the new changes, and everything works except that if >> search.jsp is activated, the Search powered by shows ?????? instead of >> either "Lucene" or "RankingAlgorithm". This works correctly if >> search-results.jsp gets activated. Atleast from what I understand, >> search.jsp seems to get activated if you click on the search button >> without entering any search terms. Both seem to use the same mechanism >> to get the resource searchConfig.key2 but in one case this seems to be >> valid and returns the right value while in the other seems to be out of >> scope and returns either a null or "????". >> >> Regards, >> - NN > ------------------------------------------------------------------------------ > Free Software Download: Index, Search& Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT data > generated by your applications, servers and devices whether physical, virtual > or in the cloud. Deliver compliance at lower cost and gain new business > insights. http://p.sf.net/sfu/splunk-dev2dev > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > > |
From: <jam...@li...> - 2011-03-02 21:19:59
|
Hi, Feel free to update any page as needed. If you could add a note that the RankingAlgorithm configuration will not be available until JAMWiki 1.1 is released it would be much appreciated. Thanks! Ryan On 3/2/2011 7:28 AM, jam...@li... wrote: > Hi Ryan: > > I would like to add a menu option to the documentation at > http://jamwiki.org/wiki/en/Configuration about being able to configure > an alternate search engine, similar to bliki parser, will this be Ok ? > > Regards, > - NN > > On 2/28/2011 9:38 PM, jam...@li... wrote: >> Hi, >> >> Thanks for the catch - revision 3484 fixes the issue for me locally, but >> let me know if you still encounter any problems. >> >> Ryan >> >> >> On 2/28/2011 8:02 PM, jam...@li... wrote: >>> Hi Ryan: >>> >>> I was testing the new changes, and everything works except that if >>> search.jsp is activated, the Search powered by shows ?????? instead of >>> either "Lucene" or "RankingAlgorithm". This works correctly if >>> search-results.jsp gets activated. Atleast from what I understand, >>> search.jsp seems to get activated if you click on the search button >>> without entering any search terms. Both seem to use the same mechanism >>> to get the resource searchConfig.key2 but in one case this seems to be >>> valid and returns the right value while in the other seems to be out of >>> scope and returns either a null or "????". >>> >>> Regards, >>> - NN >> ------------------------------------------------------------------------------ >> Free Software Download: Index, Search& Analyze Logs and other IT data in >> Real-Time with Splunk. Collect, index and harness all the fast moving IT data >> generated by your applications, servers and devices whether physical, virtual >> or in the cloud. Deliver compliance at lower cost and gain new business >> insights. http://p.sf.net/sfu/splunk-dev2dev >> _______________________________________________ >> Jamwiki-devel mailing list >> Jam...@li... >> https://lists.sourceforge.net/lists/listinfo/jamwiki-devel >> >> > > > ------------------------------------------------------------------------------ > Free Software Download: Index, Search& Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT data > generated by your applications, servers and devices whether physical, virtual > or in the cloud. Deliver compliance at lower cost and gain new business > insights. http://p.sf.net/sfu/splunk-dev2dev > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel |
From: <jam...@li...> - 2011-02-11 02:55:41
|
Thanks Mike! I am new to Maven and not familiar with it. So in your last email when you suggested making the binary available from Maven central, I assumed it to be jamwiki repository. Let me see if there is a way to eliminate this compile time dependency completely. Regards, - NN On 2/9/2011 9:14 AM, jam...@li... wrote: > jam...@li... schrieb: >> Hi Ryan: >> >> I have this working now. it works a little differently than below since >> all we need is the >> rankingalgorithm.jar to be available in the jamwiki repository. The >> rankingalgorithm.jar >> is needed for compilation, etc. to resolve linkage issues. At war build >> time, I have >> an exclude so that the rankingalgorithm.jar is not included in the war >> file being built. >> This avoids it being part of the JAMWiki distribution. >> >> After deploy, the admin can configure the RankingAlgorithm as the search >> engine. >> At save this throws up an exception that RankingAglorithm class file not >> found and >> the admin would need to copy the rankingalgorithm jar file to the >> WEB/lib directory. >> Is there someplace this could be documented on what the admin has to do ? >> >> I will go ahead and create a branch and add the new code. > Hi, > > please consider that the ranking algo jar has to be available in a > publicly accessible repo. There is no jamwiki repo. Either you host your > on repo or get a hosted one at sonatype OSS. > > The best solution for inclusion would be, as I have mentioned before, a > profile which would activate the addon module AND the dependency to it. > > Mike > > ------------------------------------------------------------------------------ > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > > |
From: <jam...@li...> - 2011-01-29 16:51:33
|
Thanks Ryan! Sounds good, the interface code RankingAlgorithmSearchEngine java can be released as LGPL, with the end users needing to download it from the RankingAlgorithm binary separately. Regards, - NN On 1/28/2011 8:47 AM, jam...@li... wrote: > Hi, > > If a package isn't released under an LGPL-compatible license then it > can't be distributed as part of the JAMWiki package since JAMWiki as a > whole is distributed as an LGPL-compatible project. However, if there > is interface code for RankingAlgorithm (for example an > org.jamwiki.SearchEngine interface) that is LGPL then that can be > included in the JAMWiki release, although end users would need to > download the RankingAlgorithm binary separately. > > Let me know if you have any additional questions. > > Cheers, > > Ryan > > > On 1/28/2011 7:48 AM, jam...@li... wrote: >> Hi Ryan: >> >> Unfortunately, this library is not released as LGPL but has its own >> license but is >> completely free for open source and non-profits projects. Can this be >> included >> in binary form only (there seems to be a classpath exception to LGPL 2.1) ? >> >> Regards, >> - NN >> >> On 1/27/2011 8:32 PM, jam...@li... wrote: >>> Hi Nagendra, >>> >>> I've added you to the developers group for JAMWiki, so you should now be >>> able to create a Subversion branch. One important note - I didn't see >>> any license information on the RankingAlgorithm site, although there are >>> a few places that mention that the technology is patent pending, so be >>> aware that all JAMWiki contributions must be licensed LGPL. >>> >>> As to your questions about translations, any translations can be done in >>> English only and committed directly to Subversion (no need to send >>> anything to this list). I'll keep an eye on Subversion commits, but if >>> there's something specific that you want reviewed please send a feedback >>> request to this list. >>> >>> Thanks for contributing! >>> >>> Ryan > ------------------------------------------------------------------------------ > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > _______________________________________________ > Jamwiki-devel mailing list > Jam...@li... > https://lists.sourceforge.net/lists/listinfo/jamwiki-devel > > |
From: <jam...@li...> - 2011-01-29 16:56:35
|
jam...@li... schrieb: > Thanks Ryan! Sounds good, the interface code > RankingAlgorithmSearchEngine java > can be released as LGPL, with the end users needing to download it from the > RankingAlgorithm binary separately. Please add your implementation into the "addons" module and make th RA jar as dep in the pom. |