Thread: [Jamwiki-devel] Bliki core dependency

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

Hi Ryan,

is there any good reason why you rely on a SNAPSHOT version? I'd like to 
fix that. Relying on such should only happen durch development and not 
for tagged releases.

Hi Mike,

> is there any good reason why you rely on a SNAPSHOT version? I'd like to
> fix that. Relying on such should only happen durch development and not
> for tagged releases.

I believe that there was an attempt to upgrade the Bliki dependency at 
one point, but that there was a conflict due to the fact that JAMWiki 
uses Java 5 while the new Bliki code was using Java 6.  Axel may be able 
to provide further insight and some advice on updating any dependencies 
as he is the Bliki maintainer.

Ryan

jam...@li... schrieb:
> Hi Mike,
> 
>> is there any good reason why you rely on a SNAPSHOT version? I'd like to
>> fix that. Relying on such should only happen durch development and not
>> for tagged releases.
> 
> I believe that there was an attempt to upgrade the Bliki dependency at 
> one point, but that there was a conflict due to the fact that JAMWiki 
> uses Java 5 while the new Bliki code was using Java 6.  Axel may be able 
> to provide further insight and some advice on updating any dependencies 
> as he is the Bliki maintainer.

Ryan,

I took a look at the 3.0.12 tag in bliki's svn. The pom's configuration 
is broken. Source and target are different. This might lead to errors.

All subsueqents poms are fine. They have 1.5 and 1.5 set. I would 
recommend to upgrade at least to 3.0.13.

Mike

Hi Mike,

> I took a look at the 3.0.12 tag in bliki's svn. The pom's configuration
> is broken. Source and target are different. This might lead to errors.
>
> All subsueqents poms are fine. They have 1.5 and 1.5 set. I would
> recommend to upgrade at least to 3.0.13.

Provided 3.0.13 (or whatever the latest version is) is Java 5-compatible 
then upgrading to that version sounds like the right solution.  I don't 
personally use the Bliki parser, but I've gotten reports from a number 
of users who do so if there are any issues with the upgrade I'm sure 
someone will report it and we can downgrade if needed.

Ryan

jam...@li... schrieb:
> Hi Mike,
> 
>> I took a look at the 3.0.12 tag in bliki's svn. The pom's configuration
>> is broken. Source and target are different. This might lead to errors.
>>
>> All subsueqents poms are fine. They have 1.5 and 1.5 set. I would
>> recommend to upgrade at least to 3.0.13.
> 
> Provided 3.0.13 (or whatever the latest version is) is Java 5-compatible 
> then upgrading to that version sounds like the right solution.  I don't 
> personally use the Bliki parser, but I've gotten reports from a number 
> of users who do so if there are any issues with the upgrade I'm sure 
> someone will report it and we can downgrade if needed.

Ryan, that's fine. I will bump to 3.0.15 and add a line in the 
changelog. A potentionally breaking change is fine because this is a 
major release. Imho nothing should be since this is just a new bugfix 
release of bliki.

Mike

jam...@li... schrieb:
> Hi Mike,
> 
>> I took a look at the 3.0.12 tag in bliki's svn. The pom's configuration
>> is broken. Source and target are different. This might lead to errors.
>>
>> All subsueqents poms are fine. They have 1.5 and 1.5 set. I would
>> recommend to upgrade at least to 3.0.13.
> 
> Provided 3.0.13 (or whatever the latest version is) is Java 5-compatible 
> then upgrading to that version sounds like the right solution.  I don't 
> personally use the Bliki parser, but I've gotten reports from a number 
> of users who do so if there are any issues with the upgrade I'm sure 
> someone will report it and we can downgrade if needed.

I was to hasty in upgrading Bliki Core to 3.0.15 and JAMWiki failed to 
compile:
[ERROR] 
/home/mosipov/Projekte/jamwiki/addons/bliki-parser/src/main/java/org/jamwiki/parser/bliki/JAMWikiModel.java:[35,7] 
org.jamwiki.parser.bliki.JAMWikiModel is not abstract and does not 
override abstract method getNamespace() in info.bliki.wiki.model.IWikiModel

Axel introduced a breaking change in a bugfix version. WTF!
Now you have seen the perfect case which I have depicted in my criticism 
of a broken versioning scheme.

I reverted back to 3.0.12 release version, all upstream versions are 
broken. Due to my lack of knowledge of the upper shown code spot, I am 
not able to fix that easily.

Are you willing to do so or do we want to stick to 3.0.12 for now?

Mike

Hi Mike,

> I was to hasty in upgrading Bliki Core to 3.0.15 and JAMWiki failed to
> compile:
> [ERROR]
> /home/mosipov/Projekte/jamwiki/addons/bliki-parser/src/main/java/org/jamwiki/parser/bliki/JAMWikiModel.java:[35,7]
> org.jamwiki.parser.bliki.JAMWikiModel is not abstract and does not
> override abstract method getNamespace() in info.bliki.wiki.model.IWikiModel

I'll take a look at this - the problem looks like it can be fixed in the 
JAMWiki interface file (which tracks JFlex parser changes) and not in 
the Bliki parser itself.  Hopefully this should be easy to work around.

Ryan

I tried taking a look at the Bliki issue but I'm still getting Java 
version errors.  It looks like the bliki-core POM specifies 1.5, but the 
Manifest of the JAR shows the following, which (I'm guessing) indicates 
that the actual JAR file in the repository may have been built without 
using the POM specfiied?

   Manifest-Version: 1.0
   Archiver-Version: Plexus Archiver
   Created-By: Apache Maven
   Built-By: Klaus
   Build-Jdk: 1.6.0

Here's the slightly-trimmed output when I try to do a Maven build:

      [exec] Downloading: 
http://gwtwiki.googlecode.com/svn/maven-repository//info/bliki/wiki/bliki-core/3.0.15/bliki-core-3.0.15.pom
      [exec] 2/2K
      [exec] 2K downloaded  (bliki-core-3.0.15.pom)Downloading: 
http://gwtwiki.googlecode.com/svn/maven-repository//info/bliki/wiki/bliki/3.0.15/bliki-3.0.15.pom
      [exec] 2402/?4429/?7224/?8079/?      Downloading: 
http://gwtwiki.googlecode.com/svn/maven-repository//info/bliki/wiki/bliki-core/3.0.15/bliki-core-3.0.15.jar
[compiler:compile {execution: default-compile}]
      [exec] [INFO] Compiling 3 source files to 
C:\ryan\code\workspace\jamwiki\wiki\trunk\addons\bliki-parser\target\classes
      [exec] [INFO] 
-------------------------------------------------------------
-----------
      [exec] [ERROR] BUILD FAILURE
      [exec] [INFO] 
-------------------------------------------------------------
-----------
      [exec] [INFO] Compilation failure
      [exec] 
C:\ryan\code\workspace\jamwiki\wiki\trunk\addons\bliki-parser\src\main\java\org\jamwiki\parser\bliki\JAMHTMLConverter.java:[3,-1] 
cannot access info.bliki.htmlcleaner.TagNode
      [exec] bad class file: 
C:\Users\Ryan\.m2\repository\info\bliki\wiki\bliki-core\3.0.15\bliki-core-3.0.15.jar(info/bliki/htmlcleaner/TagNode.class)
      [exec] class file has wrong version 50.0, should be 49.0

jam...@li... schrieb:
> I tried taking a look at the Bliki issue but I'm still getting Java 
> version errors.  It looks like the bliki-core POM specifies 1.5, but the 
> Manifest of the JAR shows the following, which (I'm guessing) indicates 
> that the actual JAR file in the repository may have been built without 
> using the POM specfiied?
> 
>    Manifest-Version: 1.0
>    Archiver-Version: Plexus Archiver
>    Created-By: Apache Maven
>    Built-By: Klaus
>    Build-Jdk: 1.6.0

Ryan,

your guess is incorrect. The manifest entry only indicates the JDK 
version the classes have been compiled with and not the class version 
itself.

I made several tests with javap (shows you the class version) with all 
release versions from the repo. They are all broken.

Example:
C:\Dokumente und 
Einstellungen\mosipov>C:\Programme\Java\jdk1.6.0_23\bin\javap.e
xe -classpath E:\Downloads\bliki-core-3.0.14.jar -verbose 
info.bliki.htmlcleaner
.TagNode | more
Compiled from "TagNode.java"
public class info.bliki.htmlcleaner.TagNode extends 
info.bliki.htmlcleaner.TagTo
ken
   SourceFile: "TagNode.java"
   minor version: 0
   major version: 50
   Constant pool:
...

http://code.google.com/p/gwtwiki/issues/detail?id=61

Additionally to this, the POM of bliki is fucked up. No fixed general 
encodings, no fixed versions. It seems like someone took Maven as an Ant 
replacement without think about the consequences.
I hardly can imagine that no one ever noticed that.

Mike

Ryan,

Axel released a working 3.0.16 version. In compiles but some stuff, as 
you noticed, has to be added.

Mike

Hi Mike,

> Axel released a working 3.0.16 version. In compiles but some stuff, as
> you noticed, has to be added.

Revision 3332 makes the necessary changes to upgrade JAMWiki to Bliki 
3.0.16.  This change could probably use some review from Axel to ensure 
that there isn't a better way to handle custom namespaces, but it 
compiles and will definitely work for anyone using the default namespaces.

Ryan

Thread: [Jamwiki-devel] Bliki core dependency

jamwiki-devel