Re: [Jamvm-general] Upcoming 2.4.2 Release - JamVM 2013-08-28 x86_64 update - improved jdk java lang test results

[Xerxes R. <xe...@za...>]

2013-09-13 16:43, Xerxes Rånby skrev:
> 2013-09-12 16:58, Andïï skrev:
>> On 12 September 2013 15:11, Xerxes Rånby <xe...@za...> wrote:
>>> 2013-09-11 22:25, Andïï skrev:
>>>> Some of you may have seen that Oracle have released u40 [0].  I'm
>>>> currently testing 2.4.2, which will bring the 2.4 branch up to date
>>>> with upstream on u40:
...
>>>> I plan to release this coming Wednesday, the 18th of September, if all
>>>> looks good by then.
>>>> Xerxes is going to look at updating JamVM support on the branch in the meantime.
...
>>> JamVM test logs, before jamvm update: ia32 & x86_64
>>>
>>> Test procedure:
>>> apt-get install mercurial
>>> apt-get build-dep openjdk-7
>>> hg clone http://icedtea.classpath.org/hg/release/icedtea7-2.4
>>> cd icedtea7-2.4
>>> ./autogen.sh
>>> ./configure --enable-jamvm --disable-system-lcms ; make ; make check
>>>
> ...
>>> https://gist.github.com/xranby/a7fcbcbb08e0b80164fb - jamvm 2.4.2pre+r41272f3d7393 ia32
>>> https://gist.github.com/xranby/87bcbec586aca4ba8c70 - jamvm 2.4.2pre+r41272f3d7393 x86_64
> ...
>>
>> Thanks!  I await the improved results from the new version :)
> 
> 
> Updated logs for JamVM x86_86 using the latest 2013-08-28 revision
> http://git.berlios.de/cgi-bin/cgit.cgi/jamvm/commit/?id=ac22c9948434e528ece451642b4ebde40953ee7e
> 
> Logs: https://gist.github.com/xranby/d8f6c5f16e0f456a0f43 - jamvm 2.4.2pre+r41272f3d7393+ 2013-08-28 x86_64
> Patch:
> http://git.berlios.de/cgi-bin/cgit.cgi/jamvm/commit/?id=ac22c9948434e528ece451642b4ebde40953ee7e
> 
...
> 
> Improvement seen after the update:
> 
> diff -Naur 7c8dceb90880616b7dd670f257961a1f5f371ec3 ac22c9948434e528ece451642b4ebde40953ee7e
> --- 7c8dceb90880616b7dd670f257961a1f5f371ec3	2013-09-13 16:22:43.909428937 +0200
> +++ ac22c9948434e528ece451642b4ebde40953ee7e	2013-09-13 16:22:14.889285035 +0200
> @@ -11,10 +11,7 @@
>  Error: compiler/6901572/Test.java
>  FAILED: compiler/6910618/Test.java
>  FAILED: compiler/6942326/Test.java
> -FAILED: compiler/6990212/Test6990212.java
> -FAILED: compiler/7088020/Test7088020.java
>  FAILED: compiler/7116216/StackOverflow.java
> -FAILED: compiler/7141637/SpreadNullArg.java
>  FAILED: compiler/7190310/Test7190310_unsafe.java
>  FAILED: compiler/7192963/TestByteVect.java
>  FAILED: compiler/7192963/TestDoubleVect.java
> @@ -72,7 +69,7 @@
>  FAILED: serviceability/7170638/SDTProbesGNULinuxTest.sh
>  FAILED: serviceability/attach/AttachWithStalePidFile.java
>  FAILED: serviceability/ParserTest.java
> -Test results: passed: 193; failed: 70; error: 3
> +Test results: passed: 196; failed: 67; error: 3
> 
> Three more hotspot tests passed after the update.
...
>  --------------- jtreg console summary for jdk ---------------
...
> I have issues running the JDK tests on this x86_64 machine in general.
> The JDK tests abort without completing using both Hotspot and JamVM.

I have run the JDK jtreg jdk java lang tests manually in order to see the new JamVM JSR 292 improvements after the update.
./openjdk.build/j2sdk-image/jre/bin/java -jar test/jtreg.jar -v1 -s openjdk/jdk/test/java/lang | tee java-lang.log

Summary of the diff in jdk java lang test results using jamvm on x86_64, before and after the update:
--- 7c8dceb90880616b7dd670f257961a1f5f371ec3-icedtea-2.4-jamvm-java-lang.log   2013-09-16 11:56:01.539380859 +0200
+++ ac22c9948434e528ece451642b4ebde40953ee7e-icedtea-2.4-jamvm-2013-08-28-java-lang.log    2013-09-16 11:54:44.426998476 +020

-FAILED: java/lang/invoke/6987555/Test6987555.java
-FAILED: java/lang/invoke/6991596/Test6991596.java
-FAILED: java/lang/invoke/6998541/Test6998541.java
-FAILED: java/lang/invoke/7157574/Test7157574.java
+Passed: java/lang/invoke/6987555/Test6987555.java
+Passed: java/lang/invoke/6991596/Test6991596.java
+Passed: java/lang/invoke/6998541/Test6998541.java
+Passed: java/lang/invoke/7157574/Test7157574.java

-FAILED: java/lang/invoke/CallSiteTest.java
+Error: java/lang/invoke/CallSiteTest.java

-FAILED: java/lang/invoke/InvokeDynamicPrintArgs.java
+Passed: java/lang/invoke/InvokeDynamicPrintArgs.java

-FAILED: java/lang/String/Split.java
+Passed: java/lang/String/Split.java

-FAILED: java/lang/Thread/ThreadStateTest.java
+Passed: java/lang/Thread/ThreadStateTest.java

-Test results: passed: 260; failed: 96; error: 22
+Test results: passed: 267; failed: 88; error: 23

Thus 7 more tests pass, no regressions seen in jdk java-lang after the update.
The FAILED -> Error test of java/lang/invoke/CallSiteTest is IMHO OK for JamVM since this CallSiteTest tests for an Hotspot specific Indify optimization in order to pass.
I recommend that we push this new 2013-08-28 update to HEAD and merge into icedtea-2.4 before the 2.4.2 release.

Cheers
Xerxes