Re: [Jamvm-general] [jamvm-general] Consider adding support for specifying memory in gigabyes via -msNg -msNG?

[Xerxes R. <xe...@za...>]

Hi Mark!

Thank you for the patch, I have included your GB memory option fix into
icedtea6, icedtea7 and icedtea 8:
http://icedtea.classpath.org/hg/icedtea/rev/9344881ce5c3

There was a typo in your last duplicate define of MB instead of a new
define of GB, I fixed this trivial error and have pushed your fix to
icedtea.

Cheers
Xerxes

mån 2011-09-26 klockan 16:56 +0800 skrev Mark David Dumlao:
> I'm sorry, that patch looked wrecked.
> 
> Here it is as an attachment.
> 
> On Mon, Sep 26, 2011 at 4:29 PM, Mark David Dumlao <mad...@gm...> wrote:
> > Hi!
> >
> > While using jamvm for icedtea, I noticed that some of my java apps
> > were failing terribly. After a grand time googling around for what
> > could have been causing the problems, I noticed that my java
> > environment did not accept memory heap arguments in terms of
> > gigabytes. That is, while for other java vms the following would have
> > worked:
> >
> >  java -Xmx1g -jar foo.jar
> >
> > Under jam I kept getting:
> >
> >   Invalid maximum heap size: -Xmx1g (min 4K)
> >   Could not create the Java virtual machine.
> >
> > It wasn't easy to google, but I noticed that size in gigabytes was
> > accepted by other vms, but not jam. On the other hand, jam would
> > happily accept size in megabytes even in excess of 1024.
> >