Re: [Jamvm-general] JamVM+GNU Classpath; -classpath option broken

[Robert L. <rob...@gm...>]

Hi,

On 1 August 2011 23:50, Dr Andrew John Hughes <ah...@re...> wrote:
> As of:
>
> commit 1b248439e88ae6cbd1471addc49e2666b8964ced
> Author: Robert Lougher <ro...@ja...>
> Date:   Fri May 6 02:30:54 2011 +0100
>
>    Unify command line options parsing
>
>    JamVM has two sets of options parsing.  The first is in the jamvm
>    executable that is the VM entry-point when used with GNU Classpath
>    (with GNU Classpath, JamVM is linked into a single standalone
>    executable, as well as libjvm.so).
>
>    The other is the options parsing within the JNI invocation API.
>    This entry-point is used when the VM is linked into another
>    process, and the VM is created via JNI.  This is the standard
>    entry point when used with OpenJDK/IcedTea.  Here, the VM
>    is started via a small launcher executable, which handles command
>    line parsing, passing arguments to the JNI invocation API.
>
>    Within these two routines, many of the options can be handled
>    identically.  However, small differences has made separating these
>    options out into a common routine difficult.  These issues have
>    now been resolved and a common routine for parsing is now used.
>
>    The motivation for the change is the OpenJDK port.  In the past,
>    the JNI invocation API only handled a subset of the special -X
>    options, but with the OpenJDK port, this is now the main entry-
>    point into the VM.
>
>    Signed-off-by: Robert Lougher <ro...@ja...>
>
> JamVM+GNU Classpath seems to be broken for any practical use as you
> can no longer pass it -classpath or -cp (even though the help still
> says you can!)
>
> It seems this was removed:
>
> -        } else if(strcmp(argv[i], "-classpath") == 0 ||
> -                  strcmp(argv[i], "-cp") == 0) {
> -
> -            if(i == argc - 1) {
> -                printf("%s : missing path list\n", argv[i]);
> -                goto exit;
> -            }
> -            args->classpath = argv[++i];
> -
>
> but nothing put in place of it.
>

You're right.  It was in some code that got moved.  Now fixed!

Thanks,
Rob.

> I've just updated to the git repo from the old CVS repo. and was trying
> to setup a JamVM-based GNU Classpath JDK for building IcedTea.  But with
> this bug I can't even run the GNU Classpath tools using JamVM.
> --
> Andrew :)
>
> Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
>
> Support Free Java!
> Contribute to GNU Classpath and IcedTea
> http://www.gnu.org/software/classpath
> http://icedtea.classpath.org
> PGP Key: F5862A37 (https://keys.indymedia.org/)
> Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37
>
> ------------------------------------------------------------------------------
> BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
> The must-attend event for mobile developers. Connect with experts.
> Get tools for creating Super Apps. See the latest technologies.
> Sessions, hands-on labs, demos & much more. Register early & save!
> http://p.sf.net/sfu/rim-blackberry-1
> _______________________________________________
> Jamvm-general mailing list
> Jam...@li...
> https://lists.sourceforge.net/lists/listinfo/jamvm-general
>