Re: [jamdb-user] Patched jamdb-update to support Ogg Vorbis

[Thomas M. <tm...@tm...>]

Hi Jens!

> > You changed the indent level so there seem to be lot of changes. Please
> > set it to '2' instead of '4' when patching jamdb-update.
> 
> Yes, I know. But I needed to change it because I applied an if-condition in 
> the beginning so that everything needed to be indented to be still readable.

Okay sorry I missed that.

> > The second one is more important: I started to split jamdb into pieces
> > to make changes (like Ogg Vorbis support) easier.
> 
> Ok, here's the ogg.pm

Thanks, I added the file to cvs, but I had to change several things.

I couldn't test it - I only checked that mp3 support isn't broken :-)
Could you test it please? Take a look at the Changelog, ENABLE_OGG and/or
ENABLE_MP3 is required in the config now (this way you only have to
install the perl modules you really use).

> There's still the problem with the genre tag. Maybe there's a problem with 
> Ogg::Vorbis::Header. It simply doesn't return anything...

No idea sorry. Anyone else ... ?


-- 
MfG Thomas Mueller - http://www.tmueller.com for pgp key (95702B3B)