Re: [jamdb-user] Patched jamdb-update to support Ogg Vorbis

[Thomas M. <tm...@tm...>]

Hi Jens,

> > You'll need Ogg::Vorbis::Header (from CPAN) to use the patched version.
> > There's still a bug regarding the genres and comments. I didn't manage to get 
> > them working. Maybe someone on the list has an idea.
> > I also have to say that I'm not an experienced programmer so that the code 
> > might not be perfect.
> > Please tell me what you think of it and how I can improve my programming 
> > style.
> 
> Lets see ;). First of All: Thomas is the main programmer of the
> command line tool. So I think he should decide if the patch goes in.

Ogg Vorbis support should be added soon yes, but there are two problems
with your patch.

The patch looks quite huge, but real changes are small I think. This is
because of 'changes' like this one:

-  # get md5sum
-  $result{MD5SUM} = get_file_md5sum($file);
+    # get md5sum
+    $result{MD5SUM} = get_file_md5sum($file);

You changed the indent level so there seem to be lot of changes. Please
set it to '2' instead of '4' when patching jamdb-update.

The second one is more important: I started to split jamdb into pieces
to make changes (like Ogg Vorbis support) easier.

I commitet my sources to cvs now but they are far from finished and
badly tested.
There you can find a module JamDB/mp3.pm
(http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/jamdb/jamdb/dbstuff/JamDB/mp3.pm?rev=1.1&content-type=text/vnd.viewcvs-markup).
Could you please supply a ogg.pm or oggvorbis.pm ? You only have to return
the same hash and I should be able to add that in a couple of minutes.

One advantage we have from that: MP3::Info and Ogg::Vorbis::Header are
only necessary if you enable mp3 or Ogg support in the config.

Thanks!


-- 
MfG Thomas Mueller - http://www.tmueller.com for pgp key (95702B3B)