Re: [Jalopy-devel] [PATCH]implements indent, array initialiser

[Marco H. <dev...@hu...>]

Hello Michael,

Michael> 1) The implements value is indented improperly in CVS

Michael> eg

Michael> public class Wiggles
Michael>   extends Foo
Michael>     implements Fooable {

Michael> when it should be
Michael> public class Wiggles
Michael>   extends Foo
Michael>   implements Fooable {

I'll look at it, but I think my dev-version does it right (I will
commit changes soon)


Michael> 2) get an index out of bounds when printing an array
Michael> initialiser like this:  (trys to access markers.getLast()
Michael> when there isnt one)

Yep, showed up during my testing a few weeks ago. Already fixed on my
drive. But I'll look at your patch anyway. Maybe it is better.


Michael> 3) Praise :-D
Michael> It took me a little while to get my head around the source,
Michael> but I have to say its all very well done. 
Michael> Good work.

We're making our way to a first stable version. 1.0b9 will be a *big*
improvement as a german insurance company was willing to do *much*
field testing.


Michael> Any plans to move to Maven or Krysalis for the building.
Michael> Although you do have a nice setup already. 

And I'm quite satisfied with it. So it depends wether the current
process can be integrated into Maven whatever or I would have to apply
many changes. I like the docbook way of things and don't want to learn
just another idiom to provide some project documentation. Otherwise,
Maven looks very promising.

-- 
Best regards,
 Marco